Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1158)

Unified Diff: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.cpp

Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix oilpan compilation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.cpp
diff --git a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.cpp b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.cpp
index 729787771e915ea552998ffae596330089c71c02..9cc5c8f2828369719ea46ee061bc124a3dc8524a 100644
--- a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.cpp
+++ b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.cpp
@@ -60,37 +60,36 @@ void PlatformSpeechSynthesizer::speak(PlatformSpeechSynthesisUtterance* utteranc
void PlatformSpeechSynthesizer::pause()
{
- if (m_webSpeechSynthesizer.get())
+ if (m_webSpeechSynthesizer)
m_webSpeechSynthesizer->pause();
}
void PlatformSpeechSynthesizer::resume()
{
- if (m_webSpeechSynthesizer.get())
+ if (m_webSpeechSynthesizer)
m_webSpeechSynthesizer->resume();
}
void PlatformSpeechSynthesizer::cancel()
{
- if (m_webSpeechSynthesizer.get())
+ if (m_webSpeechSynthesizer)
m_webSpeechSynthesizer->cancel();
}
-void PlatformSpeechSynthesizer::setVoiceList(HeapVector<Member<PlatformSpeechSynthesisVoice>>& voices)
+void PlatformSpeechSynthesizer::setVoiceList(Vector<RefPtr<PlatformSpeechSynthesisVoice>>& voices)
{
m_voiceList = voices;
}
void PlatformSpeechSynthesizer::initializeVoiceList()
{
- if (m_webSpeechSynthesizer.get())
+ if (m_webSpeechSynthesizer)
m_webSpeechSynthesizer->updateVoiceList();
}
DEFINE_TRACE(PlatformSpeechSynthesizer)
{
visitor->trace(m_speechSynthesizerClient);
- visitor->trace(m_voiceList);
visitor->trace(m_webSpeechSynthesizerClient);
}
« no previous file with comments | « third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698