third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.cpp - Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.cpp

Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix oilpan compilation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.h ('k') | third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesizer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.cpp

diff --git a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.cpp b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.cpp

index e323de442178e314bf3869a6f52bfc56a2cb3e7e..dfcd92ecf5b1956484083131de32bec1e17dc099 100644

--- a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.cpp

+++ b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.cpp

@@ -27,14 +27,14 @@

namespace blink {

-PlatformSpeechSynthesisVoice* PlatformSpeechSynthesisVoice::create(const String& voiceURI, const String& name, const String& lang, bool localService, bool isDefault)

+PassRefPtr<PlatformSpeechSynthesisVoice> PlatformSpeechSynthesisVoice::create(const String& voiceURI, const String& name, const String& lang, bool localService, bool isDefault)

{

- return new PlatformSpeechSynthesisVoice(voiceURI, name, lang, localService, isDefault);

+ return adoptRef(new PlatformSpeechSynthesisVoice(voiceURI, name, lang, localService, isDefault));

}

-PlatformSpeechSynthesisVoice* PlatformSpeechSynthesisVoice::create()

+PassRefPtr<PlatformSpeechSynthesisVoice> PlatformSpeechSynthesisVoice::create()

{

- return new PlatformSpeechSynthesisVoice();

+ return adoptRef(new PlatformSpeechSynthesisVoice);

}

PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice(const String& voiceURI, const String& name, const String& lang, bool localService, bool isDefault)