Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.h

Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix oilpan compilation Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.h
diff --git a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.h b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.h
index 219a38987c1b040dc356b2f39f2d605dc3f5fb4d..b7549ebf1c89599955b39ae95e7c898d4d1ab72d 100644
--- a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.h
+++ b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisVoice.h
@@ -27,15 +27,16 @@
#define PlatformSpeechSynthesisVoice_h
#include "platform/PlatformExport.h"
-#include "platform/heap/Handle.h"
+#include "wtf/PassRefPtr.h"
+#include "wtf/RefCounted.h"
#include "wtf/text/WTFString.h"
namespace blink {
-class PLATFORM_EXPORT PlatformSpeechSynthesisVoice final : public GarbageCollectedFinalized<PlatformSpeechSynthesisVoice> {
+class PLATFORM_EXPORT PlatformSpeechSynthesisVoice final : public RefCounted<PlatformSpeechSynthesisVoice> {
public:
- static PlatformSpeechSynthesisVoice* create(const String& voiceURI, const String& name, const String& lang, bool localService, bool isDefault);
- static PlatformSpeechSynthesisVoice* create();
+ static PassRefPtr<PlatformSpeechSynthesisVoice> create(const String& voiceURI, const String& name, const String& lang, bool localService, bool isDefault);
+ static PassRefPtr<PlatformSpeechSynthesisVoice> create();
const String& voiceURI() const { return m_voiceURI; }
void setVoiceURI(const String& voiceURI) { m_voiceURI = voiceURI; }
@@ -52,8 +53,6 @@ public:
bool isDefault() const { return m_default; }
void setIsDefault(bool isDefault) { m_default = isDefault; }
- DEFINE_INLINE_TRACE() { }
-
private:
PlatformSpeechSynthesisVoice(const String& voiceURI, const String& name, const String& lang, bool localService, bool isDefault);
PlatformSpeechSynthesisVoice();

Powered by Google App Engine
This is Rietveld 408576698