third_party/WebKit/Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp - Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp

Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix oilpan compilation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp ('k') | third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisUtterance.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp

diff --git a/third_party/WebKit/Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp b/third_party/WebKit/Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp

index fb4fe528797bb90ad180fa411ef2341cd48879eb..7101b19c6010eee3a5fbd8fef31d3b25767bd730 100644

--- a/third_party/WebKit/Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp

+++ b/third_party/WebKit/Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp

@@ -41,7 +41,7 @@ WebSpeechSynthesizerClientImpl::~WebSpeechSynthesizerClientImpl()

void WebSpeechSynthesizerClientImpl::setVoiceList(const WebVector<WebSpeechSynthesisVoice>& voices)

{

- HeapVector<Member<PlatformSpeechSynthesisVoice>> outVoices;

+ Vector<RefPtr<PlatformSpeechSynthesisVoice>> outVoices;

for (size_t i = 0; i < voices.size(); i++)

outVoices.append(voices[i]);

m_synthesizer->setVoiceList(outVoices);