third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp - Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp

Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix oilpan compilation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp

diff --git a/third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp b/third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp

index b77bd62a5a3f6b3c6fe135ecb234776417412ca5..8b7426d978c4638ffa02630d6099aaec3f0824c6 100644

--- a/third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp

+++ b/third_party/WebKit/Source/modules/speech/SpeechSynthesisVoice.cpp

@@ -27,19 +27,18 @@

namespace blink {

-SpeechSynthesisVoice* SpeechSynthesisVoice::create(PlatformSpeechSynthesisVoice* voice)

+SpeechSynthesisVoice* SpeechSynthesisVoice::create(PassRefPtr<PlatformSpeechSynthesisVoice> voice)

{

return new SpeechSynthesisVoice(voice);

}

-SpeechSynthesisVoice::SpeechSynthesisVoice(PlatformSpeechSynthesisVoice* voice)

+SpeechSynthesisVoice::SpeechSynthesisVoice(PassRefPtr<PlatformSpeechSynthesisVoice> voice)

: m_platformVoice(voice)

{

}

-DEFINE_TRACE(SpeechSynthesisVoice)

+SpeechSynthesisVoice::~SpeechSynthesisVoice()

{

- visitor->trace(m_platformVoice);

}

} // namespace blink