third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisUtterance.h - Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisUtterance.h

Issue 1617383003: Move PlatformSpeechSynthesisVoice off the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix oilpan compilation Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebSpeechSynthesizerClientImpl.cpp ('k') | third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisUtterance.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisUtterance.h

diff --git a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisUtterance.h b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisUtterance.h

index f59321dadf51f51a9f07f0005ef6429cacba6626..f86db897082f2c69b7c17d8f50a4e865f6bd53dc 100644

--- a/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisUtterance.h

+++ b/third_party/WebKit/Source/platform/speech/PlatformSpeechSynthesisUtterance.h

@@ -51,7 +51,7 @@ public:

const String& lang() const { return m_lang; }

void setLang(const String& lang) { m_lang = lang; }

- PlatformSpeechSynthesisVoice* voice() const { return m_voice; }

+ PlatformSpeechSynthesisVoice* voice() const { return m_voice.get(); }

void setVoice(PlatformSpeechSynthesisVoice* voice) { m_voice = voice; }

// Range = [0, 1] where 1 is the default.

@@ -79,7 +79,7 @@ private:

Member<PlatformSpeechSynthesisUtteranceClient> m_client;

String m_text;

String m_lang;

- Member<PlatformSpeechSynthesisVoice> m_voice;

+ RefPtr<PlatformSpeechSynthesisVoice> m_voice;

float m_volume;

float m_rate;

float m_pitch;