Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: ui/gfx/BUILD.gn

Issue 1617153002: Add TODOs for broken build code in aggregate_vector_icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/gfx/vector_icons/aggregate_vector_icons.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/BUILD.gn
diff --git a/ui/gfx/BUILD.gn b/ui/gfx/BUILD.gn
index a3cc04f36ed0c3c8836e9800f0d79a0cfa98b3e0..3bb45dd62f6abfeac0a05fc97934dd3a1c9bc23c 100644
--- a/ui/gfx/BUILD.gn
+++ b/ui/gfx/BUILD.gn
@@ -569,6 +569,11 @@ action("aggregate_vector_icons") {
]
args = [
+ # TODO(brettw) bug 535386: This should not take a directory as an input,
+ # but rather a response file listing the inputs or sometimes the build will
+ # be incorrect. In this case, Ninja won't be able to do proper dependency
+ # tracking since if a file is deleted, the command line will be the same
+ # and the action will not be re-run.
"--working_directory=" + rebase_path("vector_icons/"),
"--output_cc=" + rebase_path(vector_icons_cc_file, root_build_dir),
"--output_h=" + rebase_path(vector_icons_h_file, root_build_dir),
« no previous file with comments | « no previous file | ui/gfx/vector_icons/aggregate_vector_icons.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698