Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(686)

Unified Diff: ui/gfx/vector_icons/aggregate_vector_icons.py

Issue 1617153002: Add TODOs for broken build code in aggregate_vector_icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/gfx/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/vector_icons/aggregate_vector_icons.py
diff --git a/ui/gfx/vector_icons/aggregate_vector_icons.py b/ui/gfx/vector_icons/aggregate_vector_icons.py
index 72fbc11cc935891429ad50d5af4dcd4165131706..938f1a858fd15fffdf4a870c4045562cca17a52d 100644
--- a/ui/gfx/vector_icons/aggregate_vector_icons.py
+++ b/ui/gfx/vector_icons/aggregate_vector_icons.py
@@ -9,6 +9,10 @@ import os
import textwrap
+# TODO(brettw) bug 535386: This should not take a directory as an input, but
+# rather a response file listing the inputs or sometimes the build will be
+# incorrect.
+
def AggregateVectorIcons(working_directory, output_cc, output_h):
"""Compiles all .icon files in a directory into two C++ files.
« no previous file with comments | « ui/gfx/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698