Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Side by Side Diff: ui/gfx/BUILD.gn

Issue 1617153002: Add TODOs for broken build code in aggregate_vector_icons. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | ui/gfx/vector_icons/aggregate_vector_icons.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ui.gni") 5 import("//build/config/ui.gni")
6 import("//testing/test.gni") 6 import("//testing/test.gni")
7 7
8 if (is_android) { 8 if (is_android) {
9 import("//build/config/android/config.gni") 9 import("//build/config/android/config.gni")
10 import("//build/config/android/rules.gni") 10 import("//build/config/android/rules.gni")
(...skipping 551 matching lines...) Expand 10 before | Expand all | Expand 10 after
562 "vector_icons/zoom_minus.icon", 562 "vector_icons/zoom_minus.icon",
563 "vector_icons/zoom_plus.icon", 563 "vector_icons/zoom_plus.icon",
564 ] 564 ]
565 565
566 outputs = [ 566 outputs = [
567 vector_icons_cc_file, 567 vector_icons_cc_file,
568 vector_icons_h_file, 568 vector_icons_h_file,
569 ] 569 ]
570 570
571 args = [ 571 args = [
572 # TODO(brettw) bug 535386: This should not take a directory as an input,
573 # but rather a response file listing the inputs or sometimes the build will
574 # be incorrect. In this case, Ninja won't be able to do proper dependency
575 # tracking since if a file is deleted, the command line will be the same
576 # and the action will not be re-run.
572 "--working_directory=" + rebase_path("vector_icons/"), 577 "--working_directory=" + rebase_path("vector_icons/"),
573 "--output_cc=" + rebase_path(vector_icons_cc_file, root_build_dir), 578 "--output_cc=" + rebase_path(vector_icons_cc_file, root_build_dir),
574 "--output_h=" + rebase_path(vector_icons_h_file, root_build_dir), 579 "--output_h=" + rebase_path(vector_icons_h_file, root_build_dir),
575 ] 580 ]
576 } 581 }
577 582
578 # Looking for gfx_geometry? It's //ui/gfx/geometry:geometry 583 # Looking for gfx_geometry? It's //ui/gfx/geometry:geometry
579 584
580 source_set("test_support") { 585 source_set("test_support") {
581 testonly = true 586 testonly = true
(...skipping 197 matching lines...) Expand 10 before | Expand all | Expand 10 after
779 if (is_android) { 784 if (is_android) {
780 generate_jni("gfx_jni_headers") { 785 generate_jni("gfx_jni_headers") {
781 sources = [ 786 sources = [
782 "../android/java/src/org/chromium/ui/gfx/BitmapHelper.java", 787 "../android/java/src/org/chromium/ui/gfx/BitmapHelper.java",
783 "../android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java", 788 "../android/java/src/org/chromium/ui/gfx/DeviceDisplayInfo.java",
784 "../android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java", 789 "../android/java/src/org/chromium/ui/gfx/ViewConfigurationHelper.java",
785 ] 790 ]
786 jni_package = "gfx" 791 jni_package = "gfx"
787 } 792 }
788 } 793 }
OLDNEW
« no previous file with comments | « no previous file | ui/gfx/vector_icons/aggregate_vector_icons.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698