Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1617153002: Add TODOs for broken build code in aggregate_vector_icons. (Closed)

Created:
4 years, 11 months ago by brettw
Modified:
4 years, 11 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add TODOs for broken build code in aggregate_vector_icons. These just reference the bug on the build issue. BUG=535386 TBR=dpranke@chromium.org Committed: https://crrev.com/4302010aa64bdd17bf4d2dca6e72c43f4770250a Cr-Commit-Position: refs/heads/master@{#370765}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ui/gfx/BUILD.gn View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/gfx/vector_icons/aggregate_vector_icons.py View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
brettw
4 years, 11 months ago (2016-01-21 19:22:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1617153002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1617153002/1
4 years, 11 months ago (2016-01-21 19:24:54 UTC) #5
Dirk Pranke
lgtm
4 years, 11 months ago (2016-01-21 19:33:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 20:05:24 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 20:07:30 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4302010aa64bdd17bf4d2dca6e72c43f4770250a
Cr-Commit-Position: refs/heads/master@{#370765}

Powered by Google App Engine
This is Rietveld 408576698