Issue 16171009: switch import-w3c-tests from using print statements to logging

Issue 16171009: switch import-w3c-tests from using print statements to logging (Closed)

Created:
7 years, 6 months ago by Dirk Pranke

Modified:
7 years, 6 months ago

Reviewers:
ojan

CC:
blink-reviews, eae+blinkwatch

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

switch import-w3c-tests from using print statements to logging Also, make the unit tests pass again. R=ojan@chromium.org BUG=242329 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151345

Patch Set 2 : clean up paths a bit #

Total comments: 1

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -36 lines)			Patch
M	Tools/Scripts/webkitpy/w3c/test_converter.py	View		3 chunks	+7 lines, -3 lines	0 comments	Download
M	Tools/Scripts/webkitpy/w3c/test_converter_unittest.py	View	1	7 chunks	+8 lines, -6 lines	0 comments	Download
M	Tools/Scripts/webkitpy/w3c/test_importer.py	View		9 chunks	+38 lines, -16 lines	1 comment	Download
M	Tools/Scripts/webkitpy/w3c/test_importer_unittest.py	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
M	Tools/Scripts/webkitpy/w3c/test_parser.py	View		3 chunks	+10 lines, -4 lines	0 comments	Download
M	Tools/Scripts/webkitpy/w3c/test_parser_unittest.py	View	1	4 chunks	+4 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ojan

lgtm https://codereview.chromium.org/16171009/diff/2001/Tools/Scripts/webkitpy/w3c/test_importer.py File Tools/Scripts/webkitpy/w3c/test_importer.py (right): https://codereview.chromium.org/16171009/diff/2001/Tools/Scripts/webkitpy/w3c/test_importer.py#newcode141 Tools/Scripts/webkitpy/w3c/test_importer.py:141: if record.levelno > logging.INFO: Should this be: if ...

7 years, 6 months ago (2013-05-29 00:31:47 UTC) #2

Dirk Pranke

On 2013/05/29 00:31:47, ojan wrote: > lgtm > > https://codereview.chromium.org/16171009/diff/2001/Tools/Scripts/webkitpy/w3c/test_importer.py > File Tools/Scripts/webkitpy/w3c/test_importer.py (right): > ...

7 years, 6 months ago (2013-05-29 00:45:52 UTC) #3

Dirk Pranke

7 years, 6 months ago (2013-05-29 01:48:37 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r151345 (presubmit successful).

Expand Messages | Collapse Messages