Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2803)

Unified Diff: Tools/Scripts/webkitpy/w3c/test_importer_unittest.py

Issue 16171009: switch import-w3c-tests from using print statements to logging (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: clean up paths a bit Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
diff --git a/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py b/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
index 08ea72d79bc761c21a9a15797378a7c55eaef72c..526f1d287e6f43d5fc33f58edd666a56e9266b65 100644
--- a/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
+++ b/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py
@@ -38,6 +38,9 @@ from webkitpy.common.system.outputcapture import OutputCapture
from webkitpy.w3c.test_importer import TestImporter
+DUMMY_SOURCE_DIR = '/w3c'
+DUMMY_REPO_DIR = '/blink/LayoutTests'
+
class TestImporterTest(unittest.TestCase):
def test_import_dir_with_no_tests_and_no_hg(self):
@@ -45,7 +48,7 @@ class TestImporterTest(unittest.TestCase):
host = Host()
host.executive = MockExecutive2(exception=OSError())
- importer = TestImporter(host, None, optparse.Values({"overwrite": False}))
+ importer = TestImporter(host, DUMMY_SOURCE_DIR, DUMMY_REPO_DIR, optparse.Values({"overwrite": False}))
importer.source_directory = importer.path_from_webkit_root("Tools", "Scripts", "webkitpy", "w3c")
importer.destination_directory = tempfile.mkdtemp(prefix='csswg')
@@ -62,7 +65,7 @@ class TestImporterTest(unittest.TestCase):
host = Host()
host.executive = MockExecutive2(exception=ScriptError("abort: no repository found in '/Volumes/Source/src/wk/Tools/Scripts/webkitpy/w3c' (.hg not found)!"))
- importer = TestImporter(host, None, optparse.Values({"overwrite": False}))
+ importer = TestImporter(host, '/w3c', '/blink', optparse.Values({"overwrite": False}))
importer.source_directory = importer.path_from_webkit_root("Tools", "Scripts", "webkitpy", "w3c")
importer.destination_directory = tempfile.mkdtemp(prefix='csswg')

Powered by Google App Engine
This is Rietveld 408576698