switch import-w3c-tests from using print statements to logging

Tools/Scripts/webkitpy/w3c/test_converter.py

 #!/usr/bin/env python
 
 # Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
 # are met:
 #
 # 1. Redistributions of source code must retain the above
 #    copyright notice, this list of conditions and the following
 #    disclaimer.
 # 2. Redistributions in binary form must reproduce the above
 #    copyright notice, this list of conditions and the following
 #    disclaimer in the documentation and/or other materials
 #    provided with the distribution.
 #
 # THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDER "AS IS" AND ANY
 # EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 # IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
 # PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER BE
 # LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY,
 # OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO,
 # PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR
 # PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR
 # TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF
 # THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
 # SUCH DAMAGE.
 
+import logging
 import re
 
 from webkitpy.common.host import Host
 from webkitpy.thirdparty.BeautifulSoup import BeautifulSoup, Tag
 
 
+_log = logging.getLogger(__name__)
+
+
 class W3CTestConverter(object):
 
     def __init__(self):
         self._host = Host()
         self._filesystem = self._host.filesystem
         self._host.initialize_scm()
         self._webkit_root = self._host.scm().checkout_root
 
         # These settings might vary between WebKit and Blink
         self._css_property_file = self.path_from_webkit_root('Source', 'core', 'css', 'CSSPropertyNames.in')
@@ skipping 55 matching lines @@
 
         resources_path = self.path_from_webkit_root('LayoutTests', 'resources')
         resources_relpath = self._filesystem.relpath(resources_path, new_path)
 
         for tag in testharness_tags:
             # FIXME: We need to handle img, audio, video tags also.
             attr = 'src'
             if tag.name != 'script':
                 attr = 'href'
 
-            if not attr in tag:
+            if not attr in tag.attrMap:
                 # FIXME: Figure out what to do w/ invalid tags. For now, we return False
                 # and leave the document unmodified, which means that it'll probably fail to run.
-                print "Error: missing an attr in %s" % filename
+                _log.error("Missing an attr in %s" % filename)
                 return False
 
             old_path = tag[attr]
             new_tag = Tag(doc, tag.name, tag.attrs)
             new_tag[attr] = re.sub(pattern, resources_relpath + '/testharness', old_path)
 
             self.replace_tag(tag, new_tag)
 
         return True
 
@@ skipping 44 matching lines @@
             # FIXME: add in both the prefixed and unprefixed versions, rather than just replacing them?
             # That might allow the imported test to work in other browsers more easily.
 
             unprefixed_property = prefixed_property.replace('-webkit-', '')
 
             # Look for the various ways it might be in the CSS
             # Match the the property preceded by either whitespace or left curly brace
             # or at the beginning of the string (for inline style attribute)
             pattern = '([\s{]|^)' + unprefixed_property + '(\s+:|:)'
             if re.search(pattern, text):
-                print 'converting %s -> %s' % (unprefixed_property, prefixed_property)
+                _log.info('converting %s -> %s' % (unprefixed_property, prefixed_property))
                 converted_properties.append(prefixed_property)
                 text = re.sub(pattern, prefixed_property + ':', text)
 
         # FIXME: Handle the JS versions of these properties and GetComputedStyle, too.
         return (converted_properties, text)
 
     def replace_tag(self, old_tag, new_tag):
         index = old_tag.parent.contents.index(old_tag)
         old_tag.parent.insert(index, new_tag)
         old_tag.extract()