Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1616793004: Try a different way of unregistering TaskQueues from ThrottlingHelper (Closed)

Created:
4 years, 11 months ago by alex clarke (OOO till 29th)
Modified:
4 years, 11 months ago
Reviewers:
Sami
CC:
chromium-reviews, scheduler-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try a different way of unregistering TaskQueues from ThrottlingHelper A speculative patch to try and fix a UAF in ThrottlingHelper. BUG=579679 Committed: https://crrev.com/f6a9383746d4cb4e4b93b2576178e1e9b23a485a Cr-Commit-Position: refs/heads/master@{#370700}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M components/scheduler/renderer/renderer_scheduler_impl.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M components/scheduler/renderer/throttling_helper.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/scheduler/renderer/throttling_helper.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/scheduler/renderer/web_frame_scheduler_impl.cc View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616793004/1
4 years, 11 months ago (2016-01-21 13:48:33 UTC) #2
alex clarke (OOO till 29th)
PTAL.
4 years, 11 months ago (2016-01-21 13:57:49 UTC) #4
Sami
lgtm.
4 years, 11 months ago (2016-01-21 14:01:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616793004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616793004/1
4 years, 11 months ago (2016-01-21 14:08:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 15:44:33 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 15:45:31 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f6a9383746d4cb4e4b93b2576178e1e9b23a485a
Cr-Commit-Position: refs/heads/master@{#370700}

Powered by Google App Engine
This is Rietveld 408576698