Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Side by Side Diff: components/scheduler/renderer/renderer_scheduler_impl.cc

Issue 1616793004: Try a different way of unregistering TaskQueues from ThrottlingHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/scheduler/renderer/throttling_helper.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/renderer/renderer_scheduler_impl.h" 5 #include "components/scheduler/renderer/renderer_scheduler_impl.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/debug/stack_trace.h" 8 #include "base/debug/stack_trace.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/trace_event/trace_event.h" 10 #include "base/trace_event/trace_event.h"
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 return timer_task_queue; 217 return timer_task_queue;
218 } 218 }
219 219
220 scoped_ptr<RenderWidgetSchedulingState> 220 scoped_ptr<RenderWidgetSchedulingState>
221 RendererSchedulerImpl::NewRenderWidgetSchedulingState() { 221 RendererSchedulerImpl::NewRenderWidgetSchedulingState() {
222 return render_widget_scheduler_signals_.NewRenderWidgetSchedulingState(); 222 return render_widget_scheduler_signals_.NewRenderWidgetSchedulingState();
223 } 223 }
224 224
225 void RendererSchedulerImpl::OnUnregisterTaskQueue( 225 void RendererSchedulerImpl::OnUnregisterTaskQueue(
226 const scoped_refptr<TaskQueue>& task_queue) { 226 const scoped_refptr<TaskQueue>& task_queue) {
227 if (throttling_helper_.get())
228 throttling_helper_->UnregisterTaskQueue(task_queue.get());
229
227 if (loading_task_runners_.find(task_queue) != loading_task_runners_.end()) { 230 if (loading_task_runners_.find(task_queue) != loading_task_runners_.end()) {
228 task_queue->RemoveTaskObserver( 231 task_queue->RemoveTaskObserver(
229 &MainThreadOnly().loading_task_cost_estimator); 232 &MainThreadOnly().loading_task_cost_estimator);
230 loading_task_runners_.erase(task_queue); 233 loading_task_runners_.erase(task_queue);
231 } else if (timer_task_runners_.find(task_queue) != 234 } else if (timer_task_runners_.find(task_queue) !=
232 timer_task_runners_.end()) { 235 timer_task_runners_.end()) {
233 task_queue->RemoveTaskObserver(&MainThreadOnly().timer_task_cost_estimator); 236 task_queue->RemoveTaskObserver(&MainThreadOnly().timer_task_cost_estimator);
234 timer_task_runners_.erase(task_queue); 237 timer_task_runners_.erase(task_queue);
235 } 238 }
236 } 239 }
(...skipping 955 matching lines...) Expand 10 before | Expand all | Expand 10 after
1192 } 1195 }
1193 MainThreadOnly().have_reported_blocking_intervention_since_navigation = 1196 MainThreadOnly().have_reported_blocking_intervention_since_navigation =
1194 true; 1197 true;
1195 BroadcastConsoleWarning( 1198 BroadcastConsoleWarning(
1196 "Deferred long-running timer task(s) to improve scrolling smoothness. " 1199 "Deferred long-running timer task(s) to improve scrolling smoothness. "
1197 "See crbug.com/574343."); 1200 "See crbug.com/574343.");
1198 } 1201 }
1199 } 1202 }
1200 1203
1201 } // namespace scheduler 1204 } // namespace scheduler
OLDNEW
« no previous file with comments | « no previous file | components/scheduler/renderer/throttling_helper.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698