Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Side by Side Diff: components/scheduler/renderer/web_frame_scheduler_impl.cc

Issue 1616793004: Try a different way of unregistering TaskQueues from ThrottlingHelper (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/scheduler/renderer/throttling_helper.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/scheduler/renderer/web_frame_scheduler_impl.h" 5 #include "components/scheduler/renderer/web_frame_scheduler_impl.h"
6 6
7 #include "components/scheduler/base/real_time_domain.h" 7 #include "components/scheduler/base/real_time_domain.h"
8 #include "components/scheduler/base/virtual_time_domain.h" 8 #include "components/scheduler/base/virtual_time_domain.h"
9 #include "components/scheduler/child/web_task_runner_impl.h" 9 #include "components/scheduler/child/web_task_runner_impl.h"
10 #include "components/scheduler/renderer/renderer_scheduler_impl.h" 10 #include "components/scheduler/renderer/renderer_scheduler_impl.h"
11 #include "components/scheduler/renderer/web_view_scheduler_impl.h" 11 #include "components/scheduler/renderer/web_view_scheduler_impl.h"
12 #include "third_party/WebKit/public/platform/WebString.h" 12 #include "third_party/WebKit/public/platform/WebString.h"
13 13
14 namespace scheduler { 14 namespace scheduler {
15 15
16 WebFrameSchedulerImpl::WebFrameSchedulerImpl( 16 WebFrameSchedulerImpl::WebFrameSchedulerImpl(
17 RendererSchedulerImpl* renderer_scheduler, 17 RendererSchedulerImpl* renderer_scheduler,
18 WebViewSchedulerImpl* parent_web_view_scheduler) 18 WebViewSchedulerImpl* parent_web_view_scheduler)
19 : renderer_scheduler_(renderer_scheduler), 19 : renderer_scheduler_(renderer_scheduler),
20 parent_web_view_scheduler_(parent_web_view_scheduler), 20 parent_web_view_scheduler_(parent_web_view_scheduler),
21 visible_(true), 21 visible_(true),
22 page_in_background_(false) {} 22 page_in_background_(false) {}
23 23
24 WebFrameSchedulerImpl::~WebFrameSchedulerImpl() { 24 WebFrameSchedulerImpl::~WebFrameSchedulerImpl() {
25 if (loading_task_queue_.get()) 25 if (loading_task_queue_.get())
26 loading_task_queue_->UnregisterTaskQueue(); 26 loading_task_queue_->UnregisterTaskQueue();
27 27
28 if (timer_task_queue_.get()) { 28 if (timer_task_queue_.get())
29 renderer_scheduler_->throttling_helper()->DecreaseThrottleRefCount(
30 timer_task_queue_.get());
31 timer_task_queue_->UnregisterTaskQueue(); 29 timer_task_queue_->UnregisterTaskQueue();
32 }
33 30
34 if (parent_web_view_scheduler_) 31 if (parent_web_view_scheduler_)
35 parent_web_view_scheduler_->Unregister(this); 32 parent_web_view_scheduler_->Unregister(this);
36 } 33 }
37 34
38 void WebFrameSchedulerImpl::DetachFromWebViewScheduler() { 35 void WebFrameSchedulerImpl::DetachFromWebViewScheduler() {
39 parent_web_view_scheduler_ = nullptr; 36 parent_web_view_scheduler_ = nullptr;
40 } 37 }
41 38
42 void WebFrameSchedulerImpl::setFrameVisible(bool visible) { 39 void WebFrameSchedulerImpl::setFrameVisible(bool visible) {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
84 if (page_in_background_) { 81 if (page_in_background_) {
85 renderer_scheduler_->throttling_helper()->IncreaseThrottleRefCount( 82 renderer_scheduler_->throttling_helper()->IncreaseThrottleRefCount(
86 timer_task_queue_.get()); 83 timer_task_queue_.get());
87 } else { 84 } else {
88 renderer_scheduler_->throttling_helper()->DecreaseThrottleRefCount( 85 renderer_scheduler_->throttling_helper()->DecreaseThrottleRefCount(
89 timer_task_queue_.get()); 86 timer_task_queue_.get());
90 } 87 }
91 } 88 }
92 89
93 } // namespace scheduler 90 } // namespace scheduler
OLDNEW
« no previous file with comments | « components/scheduler/renderer/throttling_helper.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698