Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 1616743002: Use more appropriate symbol names for "shadow distributed" (Closed)

Created:
4 years, 11 months ago by kochi
Modified:
4 years, 11 months ago
Reviewers:
rune
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, hayato, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/src.git@blink_slotted_matching
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use more appropriate symbol names for "shadow distributed" The term "shadow distributed" has been used to refer to matching of "::content" pseudo element against <content> or <shadow> elements. Shadow DOM V1 introduces the new <slot> element and ::slotted pseudo element, rename all occurrences of "shadow distributed" to "content pseudo", or "slotted pseudo" etc. so it should make more sense. This CL should land after https://codereview.chromium.org/1575363006 BUG=531990 Committed: https://crrev.com/3560eab7b023bd3e0e282d8509cf2d75d0d89264 Cr-Commit-Position: refs/heads/master@{#370660}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M third_party/WebKit/Source/core/css/RuleSet.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/RuleSet.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 2 chunks +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (7 generated)
kochi
PTAL
4 years, 11 months ago (2016-01-21 07:19:29 UTC) #5
rune
lgtm
4 years, 11 months ago (2016-01-21 08:08:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1616743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1616743002/1
4 years, 11 months ago (2016-01-21 08:53:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 10:21:27 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 10:22:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3560eab7b023bd3e0e282d8509cf2d75d0d89264
Cr-Commit-Position: refs/heads/master@{#370660}

Powered by Google App Engine
This is Rietveld 408576698