Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: third_party/WebKit/Source/core/css/SelectorChecker.cpp

Issue 1616743002: Use more appropriate symbol names for "shadow distributed" (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blink_slotted_matching
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/SelectorChecker.cpp
diff --git a/third_party/WebKit/Source/core/css/SelectorChecker.cpp b/third_party/WebKit/Source/core/css/SelectorChecker.cpp
index 8fde38869a74ba53acf808314d203501da1e7d5e..d63496031445f2ea8453b3705866c72354db212a 100644
--- a/third_party/WebKit/Source/core/css/SelectorChecker.cpp
+++ b/third_party/WebKit/Source/core/css/SelectorChecker.cpp
@@ -349,7 +349,7 @@ SelectorChecker::Match SelectorChecker::matchForRelation(const SelectorCheckingC
case CSSSelector::Descendant:
if (context.selector->relationIsAffectedByPseudoContent()) {
for (Element* element = context.element; element; element = element->parentElement()) {
- if (matchForShadowDistributed(nextContext, *element, result) == SelectorMatches)
+ if (matchForPseudoContent(nextContext, *element, result) == SelectorMatches)
return SelectorMatches;
}
return SelectorFailsCompletely;
@@ -371,7 +371,7 @@ SelectorChecker::Match SelectorChecker::matchForRelation(const SelectorCheckingC
case CSSSelector::Child:
{
if (context.selector->relationIsAffectedByPseudoContent())
- return matchForShadowDistributed(nextContext, *context.element, result);
+ return matchForPseudoContent(nextContext, *context.element, result);
nextContext.isSubSelector = false;
nextContext.inRightmostCompound = false;
@@ -448,7 +448,7 @@ SelectorChecker::Match SelectorChecker::matchForRelation(const SelectorCheckingC
if (context.selector->relationIsAffectedByPseudoContent()) {
// TODO(kochi): closed mode tree should be handled as well for ::content.
for (Element* element = context.element; element; element = element->parentOrShadowHostElement()) {
- if (matchForShadowDistributed(nextContext, *element, result) == SelectorMatches)
+ if (matchForPseudoContent(nextContext, *element, result) == SelectorMatches)
return SelectorMatches;
}
return SelectorFailsCompletely;
@@ -485,7 +485,7 @@ SelectorChecker::Match SelectorChecker::matchForRelation(const SelectorCheckingC
return SelectorFailsCompletely;
}
-SelectorChecker::Match SelectorChecker::matchForShadowDistributed(const SelectorCheckingContext& context, const Element& element, MatchResult& result) const
+SelectorChecker::Match SelectorChecker::matchForPseudoContent(const SelectorCheckingContext& context, const Element& element, MatchResult& result) const
{
WillBeHeapVector<RawPtrWillBeMember<InsertionPoint>, 8> insertionPoints;
collectDestinationInsertionPoints(element, insertionPoints);

Powered by Google App Engine
This is Rietveld 408576698