Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1575363006: Implement matching part of ::slotted() pseudo element (Closed)

Created:
4 years, 11 months ago by kochi
Modified:
4 years, 11 months ago
Reviewers:
hayato, rune
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis, Timothy Loh
Base URL:
https://chromium.googlesource.com/chromium/src.git@blink_slotted_parser
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Implement matching part of ::slotted() pseudo element This CL is split off of https://codereview.chromium.org/1523843004/ and implements mathcing part of ::slotted() pseudo element. This CL depends on parsing part: https://codereview.chromium.org/1565263003/ Implements ::slotted() pseudo element, whose spec is discussed at https://github.com/w3c/webcomponents/issues/331 BUG=531990 TEST=new layout tests Committed: https://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93 Cr-Commit-Position: refs/heads/master@{#370650}

Patch Set 1 #

Patch Set 2 : wip #

Patch Set 3 : wip rebase #

Patch Set 4 : wip rebase #

Patch Set 5 : rebase #

Patch Set 6 : rebase #

Patch Set 7 : ready for review #

Total comments: 20

Patch Set 8 : Address comments #

Patch Set 9 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+172 lines, -31 lines) Patch
A third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element.html View 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change.html View 1 2 3 4 5 6 7 1 chunk +19 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change-expected.html View 1 2 3 4 5 6 7 1 chunk +4 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-expected.html View 1 2 3 4 5 6 7 1 chunk +4 lines, -13 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-shared-style.html View 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-shared-style-expected.html View 1 2 3 4 5 6 7 1 chunk +7 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/selectors/querySelector-pseudo-slotted.html View 1 2 3 4 5 6 7 1 chunk +25 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelector.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSSelectorList.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 2 3 4 5 6 7 3 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorChecker.cpp View 1 2 3 4 5 6 7 8 4 chunks +37 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/SelectorFilter.cpp View 1 2 3 4 5 6 7 2 chunks +14 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp View 1 2 3 4 2 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/SharedStyleFinder.cpp View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1616743002 Patch 1

Messages

Total messages: 17 (8 generated)
kochi
PTAL
4 years, 11 months ago (2016-01-20 09:59:30 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575363006/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575363006/120001
4 years, 11 months ago (2016-01-20 10:00:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-20 11:14:03 UTC) #7
rune
https://codereview.chromium.org/1575363006/diff/120001/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change-expected.html File third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change-expected.html (right): https://codereview.chromium.org/1575363006/diff/120001/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change-expected.html#newcode4 third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change-expected.html:4: <div id="child" style="background: green;">I should be green.</div> Unnecessary id ...
4 years, 11 months ago (2016-01-20 12:53:32 UTC) #8
kochi
Addressed comments. PTAL. https://codereview.chromium.org/1575363006/diff/120001/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change.html File third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change.html (right): https://codereview.chromium.org/1575363006/diff/120001/third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change.html#newcode2 third_party/WebKit/LayoutTests/fast/dom/shadow/slotted-pseudo-element-dynamic-attribute-change.html:2: <title>::slotted pseudo elements with dynamic attribute ...
4 years, 11 months ago (2016-01-21 05:09:37 UTC) #10
rune
lgtm https://codereview.chromium.org/1575363006/diff/120001/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp File third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp (left): https://codereview.chromium.org/1575363006/diff/120001/third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp#oldcode220 third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp:220: addRules(ruleSetForScope.get(), authorRules.shadowDistributedRules()); On 2016/01/21 05:09:37, kochi wrote: > ...
4 years, 11 months ago (2016-01-21 07:18:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1575363006/180001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1575363006/180001
4 years, 11 months ago (2016-01-21 07:21:56 UTC) #13
commit-bot: I haz the power
Committed patchset #9 (id:180001)
4 years, 11 months ago (2016-01-21 08:40:25 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 08:41:08 UTC) #17
Message was sent while issue was closed. 
Patchset 9 (id:??) landed as
https://crrev.com/38a8b698b864db5dadba51bbda82cc07d3cc2b93
Cr-Commit-Position: refs/heads/master@{#370650}

Powered by Google App Engine
This is Rietveld 408576698