DescriptionRevert of Make File-Picker modal on Linux (patchset #18 id:340001 of https://codereview.chromium.org/1233913009/ )
Reason for revert:
Breaks input events in some cases (crbug.com/579408)
Original issue's description:
> Make File-Picker modal on Linux
>
> Chromium for Linux opens a Gtk file-picker for file browsing, but it is not
> modal because there is no GtkWindow as parent of file-picker.
>
> This patch allows the X11 host window to disable input event handling to make
> a file-picker modal
>
> The original CL was reverted due to wrong DCHECK with modal_dialog_xid_:
> https://codereview.chromium.org/1243503002
>
> BUG=408481
> TEST=BrowserSelectFileDialogTest, ModalTest
>
> Committed: https://crrev.com/3bc35de4ff086027d50519c9fb40122f27eb82f4
> Cr-Commit-Position: refs/heads/master@{#360961}
TBR=erg@chromium.org,juncai@chromium.org,msw@chromium.org,sky@chromium.org,joone.hur@intel.com
BUG=408481, 579408
Review URL: https://codereview.chromium.org/1594973009
Cr-Commit-Position: refs/heads/master@{#370570}
(cherry picked from commit 0bf45553ab62cc5c97ee24bcdfbba9a0526235ea)
Committed: https://chromium.googlesource.com/chromium/src/+/d7015d8a6ceafecb85f79c4747be4f48470fdb6d
Patch Set 1 #
Messages
Total messages: 2 (1 generated)
|