Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 1616703002: Revert of Make File-Picker modal on Linux (patchset #18 id:340001 of https://codereview.chromium.or… (Closed)

Created:
4 years, 11 months ago by sadrul
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2623
Target Ref:
refs/pending/branch-heads/2623
Project:
chromium
Visibility:
Public.

Description

Revert of Make File-Picker modal on Linux (patchset #18 id:340001 of https://codereview.chromium.org/1233913009/ ) Reason for revert: Breaks input events in some cases (crbug.com/579408) Original issue's description: > Make File-Picker modal on Linux > > Chromium for Linux opens a Gtk file-picker for file browsing, but it is not > modal because there is no GtkWindow as parent of file-picker. > > This patch allows the X11 host window to disable input event handling to make > a file-picker modal > > The original CL was reverted due to wrong DCHECK with modal_dialog_xid_: > https://codereview.chromium.org/1243503002 > > BUG=408481 > TEST=BrowserSelectFileDialogTest, ModalTest > > Committed: https://crrev.com/3bc35de4ff086027d50519c9fb40122f27eb82f4 > Cr-Commit-Position: refs/heads/master@{#360961} TBR=erg@chromium.org,juncai@chromium.org,msw@chromium.org,sky@chromium.org,joone.hur@intel.com BUG=408481, 579408 Review URL: https://codereview.chromium.org/1594973009 Cr-Commit-Position: refs/heads/master@{#370570} (cherry picked from commit 0bf45553ab62cc5c97ee24bcdfbba9a0526235ea) Committed: https://chromium.googlesource.com/chromium/src/+/d7015d8a6ceafecb85f79c4747be4f48470fdb6d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -107 lines) Patch
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 4 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_interactive_uitest.cc View 1 chunk +0 lines, -44 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 3 chunks +0 lines, -15 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 4 chunks +1 line, -24 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
sadrul
4 years, 11 months ago (2016-01-21 05:37:51 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d7015d8a6ceafecb85f79c4747be4f48470fdb6d.

Powered by Google App Engine
This is Rietveld 408576698