Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(492)

Issue 1243503002: Revert of Make File-Picker modal on Linux (Closed)

Created:
2 years, 11 months ago by juncai
Modified:
2 years, 11 months ago
CC:
chromium-reviews, kalyank, tdanderson+views_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make File-Picker modal on Linux (patchset #8 id:140001 of https://codereview.chromium.org/1045443002/) Reason for revert: This patch causes DCHECK failure. Refer to: https://code.google.com/p/chromium/issues/detail?id=510957 Original issue's description: > Make File-Picker modal on Linux > > Chromium for Linux opens a Gtk file-picker for file browsing, but it is not > modal because there is no GtkWindow as parent of file-picker. > > This patch allows the X11 host window to disable input event handling to make > a file-picker modal. > > BUG=408481 > > Committed: https://crrev.com/b440cbb929e62a238f97590d79bd78333adef7ce > Cr-Commit-Position: refs/heads/master@{#338870} BUG=408481, 510957 Committed: https://crrev.com/bae7a498705ae28e2d08567928df640a7d48fa37 Cr-Commit-Position: refs/heads/master@{#339173}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -58 lines) Patch
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 4 chunks +3 lines, -13 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 3 chunks +0 lines, -15 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 3 chunks +0 lines, -21 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
juncai
Created Revert of Make File-Picker modal on Linux
2 years, 11 months ago (2015-07-16 22:01:10 UTC) #1
juncai
Please review this patch.
2 years, 11 months ago (2015-07-16 22:02:30 UTC) #2
Elliot Glaysher
lgtm
2 years, 11 months ago (2015-07-16 22:08:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1243503002/1
2 years, 11 months ago (2015-07-16 22:08:41 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 11 months ago (2015-07-16 23:51:17 UTC) #6
commit-bot: I haz the power
2 years, 11 months ago (2015-07-16 23:53:17 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bae7a498705ae28e2d08567928df640a7d48fa37
Cr-Commit-Position: refs/heads/master@{#339173}

Powered by Google App Engine
This is Rietveld 408576698