Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(2)

Issue 1594973009: Revert of Make File-Picker modal on Linux (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 9 months ago by sadrul
Modified:
1 year, 9 months ago
CC:
chromium-reviews, tfarina, tdanderson+views_chromium.org, Alexander Potapenko
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Make File-Picker modal on Linux (patchset #18 id:340001 of https://codereview.chromium.org/1233913009/ ) Reason for revert: Breaks input events in some cases (crbug.com/579408) Original issue's description: > Make File-Picker modal on Linux > > Chromium for Linux opens a Gtk file-picker for file browsing, but it is not > modal because there is no GtkWindow as parent of file-picker. > > This patch allows the X11 host window to disable input event handling to make > a file-picker modal > > The original CL was reverted due to wrong DCHECK with modal_dialog_xid_: > https://codereview.chromium.org/1243503002 > > BUG=408481 > TEST=BrowserSelectFileDialogTest, ModalTest > > Committed: https://crrev.com/3bc35de4ff086027d50519c9fb40122f27eb82f4 > Cr-Commit-Position: refs/heads/master@{#360961} TBR=erg@chromium.org,juncai@chromium.org,msw@chromium.org,sky@chromium.org,joone.hur@intel.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=408481 Committed: https://crrev.com/0bf45553ab62cc5c97ee24bcdfbba9a0526235ea Cr-Commit-Position: refs/heads/master@{#370570}

Patch Set 1 #

Patch Set 2 : merge-fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -107 lines) Patch
M chrome/browser/ui/libgtk2ui/select_file_dialog_impl_gtk2.cc View 1 4 chunks +3 lines, -15 lines 0 comments Download
M chrome/browser/ui/libgtk2ui/select_file_dialog_interactive_uitest.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 3 chunks +0 lines, -15 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 1 4 chunks +1 line, -24 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 1 1 chunk +2 lines, -9 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 9 (3 generated)
sadrul
Created Revert of Make File-Picker modal on Linux
1 year, 9 months ago (2016-01-20 22:39:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1594973009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1594973009/1
1 year, 9 months ago (2016-01-20 22:41:15 UTC) #2
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_32_ng/builds/147609) ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, ...
1 year, 9 months ago (2016-01-20 22:46:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1594973009/140001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1594973009/140001
1 year, 9 months ago (2016-01-20 23:20:39 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:140001)
1 year, 9 months ago (2016-01-21 02:19:19 UTC) #7
commit-bot: I haz the power
1 year, 9 months ago (2016-01-21 02:20:41 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bf45553ab62cc5c97ee24bcdfbba9a0526235ea
Cr-Commit-Position: refs/heads/master@{#370570}
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa