Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 161553002: Revert regression in AudioBufferSourceNode.start() with no buffer (Closed)

Created:
6 years, 10 months ago by Raymond Toy (Google)
Modified:
6 years, 9 months ago
CC:
blink-reviews, Raymond Toy
Visibility:
Public.

Description

Revert regression in AudioBufferSourceNode.start() with no buffer Fix regression introduced in https://codereview.chromium.org/54173005. That CL prevented the user from calling start() before setting a buffer source for the AudioBufferSourceNode. Previously, this was allowed and when the buffer was set it would get played. This CL brings back that behavior. The WebAudio spec is silent on this issue, but this was raised on the W3C audio list (http://lists.w3.org/Archives/Public/public-audio/2014JanMar/0059.html) and there was no apparent opposition to keeping the old behavior. This also allows http://chromium.googlecode.com/svn/trunk/samples/audio/wavetable-synth.html to work again since it calls start with null buffer which is set later. BUG=334237 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -29 lines) Patch
M Source/modules/webaudio/AudioBufferSourceNode.h View 2 chunks +1 line, -3 lines 0 comments Download
M Source/modules/webaudio/AudioBufferSourceNode.cpp View 3 chunks +13 lines, -25 lines 0 comments Download
M Source/modules/webaudio/AudioScheduledSourceNode.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
Raymond Toy (Google)
PTAL
6 years, 10 months ago (2014-02-13 17:35:19 UTC) #1
Raymond Toy (Google)
Ping
6 years, 9 months ago (2014-02-28 00:04:02 UTC) #2
Ken Russell (switch to Gerrit)
lgtm
6 years, 9 months ago (2014-02-28 00:33:29 UTC) #3
Raymond Toy (Google)
On 2014/02/28 00:33:29, Ken Russell wrote: > lgtm Thanks!
6 years, 9 months ago (2014-02-28 00:48:38 UTC) #4
Raymond Toy (Google)
The CQ bit was checked by rtoy@google.com
6 years, 9 months ago (2014-02-28 00:48:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/161553002/1
6 years, 9 months ago (2014-02-28 00:49:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/161553002/1
6 years, 9 months ago (2014-02-28 01:12:51 UTC) #7
Sergey Berezin
The CQ bit was unchecked by sergeyberezin@chromium.org
6 years, 9 months ago (2014-02-28 18:47:27 UTC) #8
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 9 months ago (2014-02-28 18:47:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtoy@google.com/161553002/1
6 years, 9 months ago (2014-02-28 18:48:04 UTC) #10
commit-bot: I haz the power
6 years, 9 months ago (2014-02-28 19:57:31 UTC) #11
Message was sent while issue was closed.
Change committed as 168161

Powered by Google App Engine
This is Rietveld 408576698