tools/telemetry/telemetry/core/util.py - Issue 16154007: [Telemetry] Add a page set option to use all cold page loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/util.py

Issue 16154007: [Telemetry] Add a page set option to use all cold page loads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move --cold-page-loads to page_cycler.py Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/util.py

diff --git a/tools/telemetry/telemetry/core/util.py b/tools/telemetry/telemetry/core/util.py

index 2fe792feccc02b74fc9e685053f7cf7d0d366dfa..9ddfed95c6436dc0f8a96c62af4466a921476f1f 100644

--- a/tools/telemetry/telemetry/core/util.py

+++ b/tools/telemetry/telemetry/core/util.py

@@ -77,11 +77,3 @@ def GetAvailableLocalPort():

tmp.close()

return port

-def CloseConnections(tab):

- """Closes all TCP sockets held open by the browser."""

- try:

- tab.ExecuteJavaScript("""window.chrome && chrome.benchmarking &&

- chrome.benchmarking.closeConnections()""")

- except Exception:

- pass