Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: tools/telemetry/telemetry/page/page_runner.py

Issue 16154007: [Telemetry] Add a page set option to use all cold page loads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Move --cold-page-loads to page_cycler.py Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page/page_runner.py
diff --git a/tools/telemetry/telemetry/page/page_runner.py b/tools/telemetry/telemetry/page/page_runner.py
index 8f5aec0924f4edc3d07eb61f7d60ac47ae603188..22f4ba65b5bd58504df03b3c2378b65d2d83705e 100644
--- a/tools/telemetry/telemetry/page/page_runner.py
+++ b/tools/telemetry/telemetry/page/page_runner.py
@@ -142,6 +142,10 @@ class PageRunner(object):
self._RunPage(options, page, state.tab, test,
results_for_current_run)
self._CheckThermalThrottling(state.browser.platform)
+ if options.cold_page_loads:
nduca 2013/06/06 22:49:04 i'm a little confused about how you're saying clea
tonyg 2013/06/20 02:42:29 Good point. Fixed.
+ state.browser.ClearCache()
+ else:
+ state.browser.CloseConnections()
except exceptions.TabCrashException:
stdout = ''
if not options.show_stdout:
@@ -233,7 +237,6 @@ class PageRunner(object):
try:
self._PreparePage(page, tab, page_state, test, results)
test.Run(options, page, tab, results)
- util.CloseConnections(tab)
except page_test.Failure:
logging.warning('%s:\n%s', page.url, traceback.format_exc())
results.AddFailure(page, sys.exc_info())

Powered by Google App Engine
This is Rietveld 408576698