tools/telemetry/telemetry/core/chrome/cros_browser_backend.py - Issue 16154007: [Telemetry] Add a page set option to use all cold page loads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

Issue 16154007: [Telemetry] Add a page set option to use all cold page loads. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Move --cold-page-loads to page_cycler.py Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

diff --git a/tools/telemetry/telemetry/core/chrome/cros_browser_backend.py b/tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

index a422e9f07073b76fa85a688c2f50304576695e7a..996a869a08e87f2d960cf1699bf5f5092dc795a0 100644

--- a/tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

+++ b/tools/telemetry/telemetry/core/chrome/cros_browser_backend.py

@@ -106,9 +106,9 @@ class CrOSBrowserBackend(browser_backend.BrowserBackend):

# Without --skip-hwid-check (introduced in crrev.com/203397), devices/VMs

# will be stuck on the bad hwid screen.

if self.chrome_branch_number <= 1500 and not self.hwid:

- raise exceptions.LoginException(

- 'Hardware id not set on device/VM. --skip-hwid-check not supported '

- 'with chrome branches 1500 or earlier.')

+ raise exceptions.LoginException(

+ 'Hardware id not set on device/VM. --skip-hwid-check not supported '

+ 'with chrome branches 1500 or earlier.')

if self._is_guest:

cros_util.NavigateGuestLogin(self, cri)