Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 1615173002: Revert of [profiler] Implement POC Sampling Heap Profiler (Closed)

Created:
4 years, 11 months ago by ofrobots
Modified:
4 years, 11 months ago
CC:
Hannes Payer (out of office), Paweł Hajdan Jr., ulan, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [profiler] Implement POC Sampling Heap Profiler (patchset #12 id:220001 of https://codereview.chromium.org/1555553002/ ) Reason for revert: The random nature of the tests caused the following buildbot to fail: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20gcc%204.8/builds/4724/steps/Check/logs/stdio Original issue's description: > [profiler] Implement POC Sampling Heap Profiler > > This implements a proof-of-concept sampling based heap profiler inspired by > tcmalloc's heap profiler [1] and Go's mprof/memprofile [2]. > > The basic idea is the sample allocations using a randomized Poisson process. At > any point in time we can cheaply request the set of live sample objects that > should be a representative sample of heap. Samples include stack-traces from the > allocation sites, making this an effective tool for memory leak debugging. > > Unlike AllocationTracking, this is intended to be cheap and usable online in > production. > > The proof-of-concept is only sampling new-space allocations at this point. > Support for sampling paged space and native allocations is anticipated in the > future. > > [1] http://goog-perftools.sourceforge.net/doc/heap_profiler.html > [2] http://blog.golang.org/profiling-go-programs > > Committed: https://crrev.com/e5a9947811db9c9e23557dbad27f8b8a349b3262 > Cr-Commit-Position: refs/heads/master@{#33448} TBR=jochen@chromium.org,alph@chromium.org,hpayer@chromium.org,yangguo@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/77df8659c2c114a59450dc201881f91412f200f3 Cr-Commit-Position: refs/heads/master@{#33449}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -773 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M include/v8-profiler.h View 2 chunks +0 lines, -127 lines 0 comments Download
M src/api.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/heap/heap.h View 2 chunks +0 lines, -55 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/spaces.h View 2 chunks +48 lines, -1 line 0 comments Download
M src/isolate.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M src/profiler/heap-profiler.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/profiler/heap-profiler.cc View 2 chunks +0 lines, -26 lines 0 comments Download
D src/profiler/sampling-heap-profiler.h View 1 chunk +0 lines, -135 lines 0 comments Download
D src/profiler/sampling-heap-profiler.cc View 1 chunk +0 lines, -250 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 chunk +0 lines, -145 lines 0 comments Download
M tools/gyp/v8.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
ofrobots
Created Revert of [profiler] Implement POC Sampling Heap Profiler
4 years, 11 months ago (2016-01-21 21:53:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615173002/1
4 years, 11 months ago (2016-01-21 21:53:18 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-21 21:53:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615173002/1
4 years, 11 months ago (2016-01-21 22:08:11 UTC) #6
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-21 22:08:13 UTC) #8
adamk
lgtm
4 years, 11 months ago (2016-01-21 22:08:24 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1615173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1615173002/1
4 years, 11 months ago (2016-01-21 22:08:31 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 22:08:50 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 22:09:01 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77df8659c2c114a59450dc201881f91412f200f3
Cr-Commit-Position: refs/heads/master@{#33449}

Powered by Google App Engine
This is Rietveld 408576698