Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1148)

Unified Diff: src/profiler/heap-profiler.cc

Issue 1615173002: Revert of [profiler] Implement POC Sampling Heap Profiler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/profiler/heap-profiler.h ('k') | src/profiler/sampling-heap-profiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profiler/heap-profiler.cc
diff --git a/src/profiler/heap-profiler.cc b/src/profiler/heap-profiler.cc
index 1305cae66ea1ad097c1a726705ebdbb604a556cf..4403e5d6c9c965cea6851644097200f90b6a64e8 100644
--- a/src/profiler/heap-profiler.cc
+++ b/src/profiler/heap-profiler.cc
@@ -8,7 +8,6 @@
#include "src/debug/debug.h"
#include "src/profiler/allocation-tracker.h"
#include "src/profiler/heap-snapshot-generator-inl.h"
-#include "src/profiler/sampling-heap-profiler.h"
namespace v8 {
namespace internal {
@@ -85,31 +84,6 @@
}
-bool HeapProfiler::StartSamplingHeapProfiler(uint64_t sample_interval,
- int stack_depth) {
- if (sampling_heap_profiler_.get()) {
- return false;
- }
- sampling_heap_profiler_.Reset(new SamplingHeapProfiler(
- heap(), names_.get(), sample_interval, stack_depth));
- return true;
-}
-
-
-void HeapProfiler::StopSamplingHeapProfiler() {
- sampling_heap_profiler_.Reset(nullptr);
-}
-
-
-v8::AllocationProfile* HeapProfiler::GetAllocationProfile() {
- if (sampling_heap_profiler_.get()) {
- return sampling_heap_profiler_->GetAllocationProfile();
- } else {
- return nullptr;
- }
-}
-
-
void HeapProfiler::StartHeapObjectsTracking(bool track_allocations) {
ids_->UpdateHeapObjectsMap();
is_tracking_object_moves_ = true;
« no previous file with comments | « src/profiler/heap-profiler.h ('k') | src/profiler/sampling-heap-profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698