Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: test/cctest/test-heap-profiler.cc

Issue 1615173002: Revert of [profiler] Implement POC Sampling Heap Profiler (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/profiler/sampling-heap-profiler.cc ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 2834 matching lines...) Expand 10 before | Expand all | Expand 10 after
2845 map.AddRange(ToAddress(0x180), 0x80, 6U); 2845 map.AddRange(ToAddress(0x180), 0x80, 6U);
2846 map.AddRange(ToAddress(0x180), 0x80, 7U); 2846 map.AddRange(ToAddress(0x180), 0x80, 7U);
2847 CHECK_EQ(7u, map.GetTraceNodeId(ToAddress(0x180))); 2847 CHECK_EQ(7u, map.GetTraceNodeId(ToAddress(0x180)));
2848 CHECK_EQ(5u, map.GetTraceNodeId(ToAddress(0x200))); 2848 CHECK_EQ(5u, map.GetTraceNodeId(ToAddress(0x200)));
2849 CHECK_EQ(3u, map.size()); 2849 CHECK_EQ(3u, map.size());
2850 2850
2851 map.Clear(); 2851 map.Clear();
2852 CHECK_EQ(0u, map.size()); 2852 CHECK_EQ(0u, map.size());
2853 CHECK_EQ(0u, map.GetTraceNodeId(ToAddress(0x400))); 2853 CHECK_EQ(0u, map.GetTraceNodeId(ToAddress(0x400)));
2854 } 2854 }
2855
2856
2857 static const v8::AllocationProfile::Node* FindAllocationProfileNode(
2858 v8::AllocationProfile& profile, const Vector<const char*>& names) {
2859 v8::AllocationProfile::Node* node = profile.GetRootNode();
2860 for (int i = 0; node != nullptr && i < names.length(); ++i) {
2861 const char* name = names[i];
2862 auto children = node->children;
2863 node = nullptr;
2864 for (v8::AllocationProfile::Node* child : children) {
2865 v8::String::Utf8Value child_name(child->name);
2866 if (strcmp(*child_name, name) == 0) {
2867 node = child;
2868 break;
2869 }
2870 }
2871 }
2872 return node;
2873 }
2874
2875
2876 TEST(SamplingHeapProfiler) {
2877 v8::HandleScope scope(v8::Isolate::GetCurrent());
2878 LocalContext env;
2879 v8::HeapProfiler* heap_profiler = env->GetIsolate()->GetHeapProfiler();
2880
2881 // Turn off always_opt. Inlining can cause stack traces to be shorter than
2882 // what we expect in this test.
2883 v8::internal::FLAG_always_opt = false;
2884
2885 const char* script_source =
2886 "var A = [];\n"
2887 "function bar(size) { return new Array(size); }\n"
2888 "var foo = function() {\n"
2889 " for (var i = 0; i < 1024; ++i) {\n"
2890 " A[i] = bar(1024);\n"
2891 " }\n"
2892 "}\n"
2893 "foo();";
2894
2895 // Sample should be empty if requested before sampling has started.
2896 {
2897 v8::AllocationProfile* profile = heap_profiler->GetAllocationProfile();
2898 CHECK(profile == nullptr);
2899 }
2900
2901 int count_512kb = 0;
2902 {
2903 heap_profiler->StartSamplingHeapProfiler(512 * 1024);
2904 CompileRun(script_source);
2905
2906 v8::base::SmartPointer<v8::AllocationProfile> profile(
2907 heap_profiler->GetAllocationProfile());
2908 CHECK(!profile.is_empty());
2909
2910 const char* names[] = {"", "foo", "bar"};
2911 auto node_bar = FindAllocationProfileNode(
2912 *profile, Vector<const char*>(names, arraysize(names)));
2913 CHECK(node_bar);
2914
2915 // Count the number of allocations we sampled from bar.
2916 for (auto allocation : node_bar->allocations) {
2917 count_512kb += allocation.count;
2918 }
2919
2920 heap_profiler->StopSamplingHeapProfiler();
2921 }
2922
2923 // Samples should get cleared once sampling is stopped.
2924 {
2925 v8::AllocationProfile* profile = heap_profiler->GetAllocationProfile();
2926 CHECK(profile == nullptr);
2927 }
2928
2929 // Sampling at a higher rate should give us more sampled objects.
2930 {
2931 heap_profiler->StartSamplingHeapProfiler(32 * 1024);
2932 CompileRun(script_source);
2933
2934 v8::base::SmartPointer<v8::AllocationProfile> profile(
2935 heap_profiler->GetAllocationProfile());
2936 CHECK(!profile.is_empty());
2937
2938 const char* names[] = {"", "foo", "bar"};
2939 auto node_bar = FindAllocationProfileNode(
2940 *profile, Vector<const char*>(names, arraysize(names)));
2941 CHECK(node_bar);
2942
2943 // Count the number of allocations we sampled from bar.
2944 int count_32kb = 0;
2945 for (auto allocation : node_bar->allocations) {
2946 count_32kb += allocation.count;
2947 }
2948
2949 // We should have roughly 16x as many sampled allocations. However, since
2950 // sampling is a randomized process, we use a weaker test.
2951 CHECK_GT(count_32kb, count_512kb);
2952
2953 heap_profiler->StopSamplingHeapProfiler();
2954 }
2955
2956 // A more complicated test cases with deeper call graph and dynamically
2957 // generated function names.
2958 {
2959 heap_profiler->StartSamplingHeapProfiler(128);
2960 CompileRun(record_trace_tree_source);
2961
2962 v8::base::SmartPointer<v8::AllocationProfile> profile(
2963 heap_profiler->GetAllocationProfile());
2964 CHECK(!profile.is_empty());
2965
2966 const char* names1[] = {"", "start", "f_0_0", "f_0_1", "f_0_2"};
2967 auto node1 = FindAllocationProfileNode(
2968 *profile, Vector<const char*>(names1, arraysize(names1)));
2969 CHECK(node1);
2970
2971 const char* names2[] = {"", "generateFunctions"};
2972 auto node2 = FindAllocationProfileNode(
2973 *profile, Vector<const char*>(names2, arraysize(names2)));
2974 CHECK(node2);
2975
2976 heap_profiler->StopSamplingHeapProfiler();
2977 }
2978 }
2979
2980
2981 TEST(SamplingHeapProfilerApiAllocation) {
2982 v8::HandleScope scope(v8::Isolate::GetCurrent());
2983 LocalContext env;
2984 v8::HeapProfiler* heap_profiler = env->GetIsolate()->GetHeapProfiler();
2985
2986 heap_profiler->StartSamplingHeapProfiler(256);
2987
2988 for (int i = 0; i < 8 * 1024; ++i) v8::Object::New(env->GetIsolate());
2989
2990 v8::base::SmartPointer<v8::AllocationProfile> profile(
2991 heap_profiler->GetAllocationProfile());
2992 CHECK(!profile.is_empty());
2993 const char* names[] = {"(V8 API)"};
2994 auto node = FindAllocationProfileNode(
2995 *profile, Vector<const char*>(names, arraysize(names)));
2996 CHECK(node);
2997
2998 heap_profiler->StopSamplingHeapProfiler();
2999 }
OLDNEW
« no previous file with comments | « src/profiler/sampling-heap-profiler.cc ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698