Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 1615073005: Revert of Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly (Closed)

Created:
4 years, 11 months ago by ramant (doing other things)
Modified:
4 years, 11 months ago
Reviewers:
Shu Chen, eroman, yukawa, sky
CC:
chromium-reviews, nona+watch_chromium.org, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly called. (patchset #21 id:400001 of https://codereview.chromium.org/1566083002/ ) Reason for revert: Very high crash rate. BUG=579910 Original issue's description: > Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly called. > > BUG=569339, 505231 > TEST=None > > Committed: https://crrev.com/d6b55d458f5d3ebeba2826520f14b4bf0e571396 > Cr-Commit-Position: refs/heads/master@{#370340} TBR=yukawa@chromium.org,sky@chromium.org,eroman@chromium.org,shuchen@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=569339, 505231 Committed: https://crrev.com/e28cba0046d4a29f78ba8efc5bb96036a27cd2b5 Cr-Commit-Position: refs/heads/master@{#370828}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -188 lines) Patch
M chrome/browser/ui/views/frame/browser_view.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/base/ime/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/base/ime/input_method.h View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/base/ime/input_method_auralinux.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M ui/base/ime/input_method_base.h View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/base/ime/input_method_base.cc View 3 chunks +4 lines, -10 lines 0 comments Download
D ui/base/ime/input_method_log_collector.h View 1 chunk +0 lines, -36 lines 0 comments Download
D ui/base/ime/input_method_log_collector.cc View 1 chunk +0 lines, -56 lines 0 comments Download
M ui/base/ime/input_method_win.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M ui/base/ime/mock_input_method.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/base/ime/mock_input_method.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/base/ime/ui_base_ime.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 2 chunks +1 line, -7 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 6 chunks +2 lines, -15 lines 0 comments Download
M ui/views/win/hwnd_message_handler_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ramant (doing other things)
Created Revert of Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly ...
4 years, 11 months ago (2016-01-21 22:19:03 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e28cba0046d4a29f78ba8efc5bb96036a27cd2b5 Cr-Commit-Position: refs/heads/master@{#370828}
4 years, 11 months ago (2016-01-21 23:33:19 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 23:33:30 UTC) #5
Message was sent while issue was closed.
CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615073005/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615073005/1

Powered by Google App Engine
This is Rietveld 408576698