chrome/browser/ui/views/frame/browser_view.cc - Issue 1615073005: Revert of Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 1615073005: Revert of Makes sure the keyboard typing isn't blocked when InputMethod::OnFocus() is not correctly (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 446a75f0e2d660e6bb4c98c26634b1bb84073ced..79813495c0a78c7b77b8f625aeebe2ce1de9b01b 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -126,7 +126,6 @@

#include "ui/accessibility/ax_view_state.h"

#include "ui/base/accelerators/accelerator.h"

#include "ui/base/hit_test.h"

-#include "ui/base/ime/input_method.h"

#include "ui/base/l10n/l10n_util.h"

#include "ui/base/resource/material_design/material_design_controller.h"

#include "ui/base/resource/resource_bundle.h"

@@ -1707,8 +1706,6 @@

FROM_HERE, base::Bind(&BrowserView::ActivateAppModalDialog,

activate_modal_dialog_factory_.GetWeakPtr()));

#endif

- GetNativeWindow()->GetHost()->GetInputMethod()->GetLogCollector()->AddString(

- "BrowserView cannot be activated.");

return false;

}

« no previous file with comments | « no previous file | ui/base/ime/BUILD.gn » ('j') | no next file with comments »