Start of display management for mus

Start of display management for mus

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}

Committed: https://crrev.com/a57d9927dcb3a8548eae83450c8fe1ee7e3b568b
Cr-Commit-Position: refs/heads/master@{#371059}

[Ben Goodger (Google), 2016-01-22 00:06:36]

lgtm

[rjkroege, 2016-01-22 00:08:43]

On 2016/01/21 23:42:19, sky wrote:

mus-as-a-platform question: which system component should maintain mirroring and
display positioning information? I would think that ash should manage? and what
about union mode? union mode would seem to require mus to present the illusion
of a single display?

[sky, 2016-01-22 00:15:02]

I actually hadn't thought that far through it. Perhaps mus has some
delegate that can configure this information. Basically a
DisplayDelegate that is queried when displays are added/removed for
this information.

  -Scott

On Thu, Jan 21, 2016 at 4:08 PM,  <rjkroege@chromium.org> wrote:
> On 2016/01/21 23:42:19, sky wrote:
>
> mus-as-a-platform question: which system component should maintain mirroring
> and
> display positioning information? I would think that ash should manage? and
> what
> about union mode? union mode would seem to require mus to present the
> illusion
> of a single display?
>
>
>
> https://codereview.chromium.org/1615023004/

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[sky, 2016-01-22 00:18:18]

The CQ bit was checked by sky@chromium.org

[commit-bot: I haz the power, 2016-01-22 00:20:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615023004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615023004/60001

[commit-bot: I haz the power, 2016-01-22 00:46:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-22 00:46:03]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[sky, 2016-01-22 01:07:50]

The CQ bit was checked by sky@chromium.org

[sky, 2016-01-22 01:07:50]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1615023004/#ps80001
(title: "update gyp")

[commit-bot: I haz the power, 2016-01-22 01:09:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615023004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615023004/80001

[commit-bot: I haz the power, 2016-01-22 02:26:12]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-01-22 02:27:10]

Description was changed from

==========
Start of display management for mus

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org
==========

to

==========
Start of display management for mus

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}
==========

[commit-bot: I haz the power, 2016-01-22 02:27:11]

Patchset 5 (id:??) landed as
https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}

[Elliot Glaysher, 2016-01-22 19:09:36]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1618963005/ by erg@chromium.org.

The reason for reverting is: Consistently causing crashes on mash startup:

[0122/110054:FATAL:default_logger_impl.cc(51)] Check failed: ptr_. 
#0 0x7fc46007507e base::debug::StackTrace::StackTrace()
#1 0x7fc4600c0bcf logging::LogMessage::~LogMessage()
#2 0x7fc45fe9ac30 mojo::internal::(anonymous namespace)::LogMessage()
#3 0x7fc45fe9a2e5 mojo::internal::LogMessage::~LogMessage()
#4 0x7fc45de1a33c mojo::StructPtr<>::operator->()
#5 0x7fc45fff3fc7 mus::ws::ConnectionManager::AddObserver()
#6 0x7fc45fe327f3 mus::mojom::DisplayManagerStub::Accept()
#7 0x7fc45fe07f64 mojo::internal::Router::HandleIncomingMessage()
#8 0x7fc45fe07b41 mojo::internal::Router::HandleIncomingMessageThunk::Accept()
#9 0x7fc45fe32a9e mus::mojom::DisplayManagerRequestValidator::Accept()
.

[sky, 2016-01-22 21:06:43]

Description was changed from

==========
Start of display management for mus

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}
==========

to

==========
Start of display management for mus

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}
==========

[sky, 2016-01-22 21:07:39]

This was reverted because of a crash. I've fixed it and added back getting frame
insets. I'm going to reland.

[sky, 2016-01-22 21:07:44]

The CQ bit was checked by sky@chromium.org

[sky, 2016-01-22 21:07:44]

The patchset sent to the CQ was uploaded after l-g-t-m from ben@chromium.org
Link to the patchset: https://codereview.chromium.org/1615023004/#ps120001
(title: "fix crash and add back getting constants")

[commit-bot: I haz the power, 2016-01-22 21:08:43]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1615023004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1615023004/120001

[commit-bot: I haz the power, 2016-01-22 22:28:30]

Description was changed from

==========
Start of display management for mus

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}
==========

to

==========
Start of display management for mus

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}
==========

[commit-bot: I haz the power, 2016-01-22 22:28:31]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-01-22 22:30:19]

Description was changed from

==========
Start of display management for mus

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}
==========

to

==========
Start of display management for mus

This adds a DisplayManager interface that you get from mus. You can
then attach an observer to observe display related changes.

BUG=548429
TEST=none
R=ben@chromium.org

Committed: https://crrev.com/bc2281a7a7576f5b4da85986298322b3c9d2234e
Cr-Commit-Position: refs/heads/master@{#370880}

Committed: https://crrev.com/a57d9927dcb3a8548eae83450c8fe1ee7e3b568b
Cr-Commit-Position: refs/heads/master@{#371059}
==========

[commit-bot: I haz the power, 2016-01-22 22:30:20]

Patchset 7 (id:??) landed as
https://crrev.com/a57d9927dcb3a8548eae83450c8fe1ee7e3b568b
Cr-Commit-Position: refs/heads/master@{#371059}