DescriptionRevert of Implement PopupMenu::updateFromElement() for ExternalPopupMenu. (patchset #2 id:20001 of https://codereview.chromium.org/1605233002/ )
Reason for revert:
caused a regression, crbug.com/579895
Original issue's description:
> Implement PopupMenu::updateFromElement() for ExternalPopupMenu.
>
> It closes a shown popup, and re-show a popup with the latest content.
> This CL affects only OSX and Android.
>
> Implementation:
> A major part of show() was moved to showInternal(), and updateFromElement() calls
> showInternal() later. showInternal() returns false if it failed to show a popup.
>
> BUG=176241
> TEST=manual; See crbug.com/176241.
>
> Committed: https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606
> Cr-Commit-Position: refs/heads/master@{#370329}
TBR=keishi@chromium.org
NOTRY=true
BUG=176241, 579895
Committed: https://crrev.com/e3f162c974456d915d29c8b98ddda040de1cd12e
Cr-Commit-Position: refs/heads/master@{#370657}
Patch Set 1 #
Messages
Total messages: 7 (3 generated)
|