Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1613813002: Revert of Implement PopupMenu::updateFromElement() for ExternalPopupMenu. (Closed)

Created:
4 years, 11 months ago by tkent
Modified:
4 years, 11 months ago
Reviewers:
keishi
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Implement PopupMenu::updateFromElement() for ExternalPopupMenu. (patchset #2 id:20001 of https://codereview.chromium.org/1605233002/ ) Reason for revert: caused a regression, crbug.com/579895 Original issue's description: > Implement PopupMenu::updateFromElement() for ExternalPopupMenu. > > It closes a shown popup, and re-show a popup with the latest content. > This CL affects only OSX and Android. > > Implementation: > A major part of show() was moved to showInternal(), and updateFromElement() calls > showInternal() later. showInternal() returns false if it failed to show a popup. > > BUG=176241 > TEST=manual; See crbug.com/176241. > > Committed: https://crrev.com/f32f9fad19a8366c837e3d10112001c8e7d42606 > Cr-Commit-Position: refs/heads/master@{#370329} TBR=keishi@chromium.org NOTRY=true BUG=176241, 579895 Committed: https://crrev.com/e3f162c974456d915d29c8b98ddda040de1cd12e Cr-Commit-Position: refs/heads/master@{#370657}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -61 lines) Patch
M third_party/WebKit/Source/core/html/HTMLSelectElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.h View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/ExternalPopupMenu.cpp View 4 chunks +20 lines, -56 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tkent
Created Revert of Implement PopupMenu::updateFromElement() for ExternalPopupMenu.
4 years, 11 months ago (2016-01-21 09:54:21 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1613813002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1613813002/1
4 years, 11 months ago (2016-01-21 09:56:18 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 10:01:01 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 10:02:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e3f162c974456d915d29c8b98ddda040de1cd12e
Cr-Commit-Position: refs/heads/master@{#370657}

Powered by Google App Engine
This is Rietveld 408576698