Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: third_party/WebKit/Source/web/ExternalPopupMenu.h

Issue 1613813002: Revert of Implement PopupMenu::updateFromElement() for ExternalPopupMenu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google Inc. All rights reserved. 2 * Copyright (C) 2010 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 60 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 void hide() override; 71 void hide() override;
72 void updateFromElement() override; 72 void updateFromElement() override;
73 void disconnectClient() override; 73 void disconnectClient() override;
74 74
75 // WebExternalPopupClient methods: 75 // WebExternalPopupClient methods:
76 void didChangeSelection(int index) override; 76 void didChangeSelection(int index) override;
77 void didAcceptIndex(int index) override; 77 void didAcceptIndex(int index) override;
78 void didAcceptIndices(const WebVector<int>& indices) override; 78 void didAcceptIndices(const WebVector<int>& indices) override;
79 void didCancel() override; 79 void didCancel() override;
80 80
81 bool showInternal();
82 void dispatchEvent(Timer<ExternalPopupMenu>*); 81 void dispatchEvent(Timer<ExternalPopupMenu>*);
83 void update();
84 82
85 RawPtrWillBeMember<HTMLSelectElement> m_ownerElement; 83 RawPtrWillBeMember<HTMLSelectElement> m_ownerElement;
86 RefPtrWillBeMember<LocalFrame> m_localFrame; 84 RefPtrWillBeMember<LocalFrame> m_localFrame;
87 WebViewImpl& m_webView; 85 WebViewImpl& m_webView;
88 OwnPtr<WebMouseEvent> m_syntheticEvent; 86 OwnPtr<WebMouseEvent> m_syntheticEvent;
89 Timer<ExternalPopupMenu> m_dispatchEventTimer; 87 Timer<ExternalPopupMenu> m_dispatchEventTimer;
90 // The actual implementor of the show menu. 88 // The actual implementor of the show menu.
91 WebExternalPopupMenu* m_webExternalPopupMenu; 89 WebExternalPopupMenu* m_webExternalPopupMenu;
92 bool m_needsUpdate = false;
93 }; 90 };
94 91
95 } // namespace blink 92 } // namespace blink
96 93
97 #endif // ExternalPopupMenu_h 94 #endif // ExternalPopupMenu_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLSelectElement.cpp ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698