Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Unified Diff: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp

Issue 1613813002: Revert of Implement PopupMenu::updateFromElement() for ExternalPopupMenu. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/ExternalPopupMenu.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
index 8589ce73c29f8cb0ede2c804e698777067a8a671..ad4c1d65e14891a663eb1110f58b3a3e37fa2def 100644
--- a/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLSelectElement.cpp
@@ -1984,9 +1984,9 @@
m_popupIsVisible = true;
LayoutMenuList* menuList = toLayoutMenuList(layoutObject());
+ FloatQuad quad(menuList->localToAbsoluteQuad(FloatQuad(menuList->borderBoundingBox())));
IntSize size = pixelSnappedIntRect(menuList->frameRect()).size();
- // TODO(tkent): Remove show() arguments. They are unused.
- m_popup->show(FloatQuad(), size, optionToListIndex(selectedIndex()));
+ m_popup->show(quad, size, optionToListIndex(selectedIndex()));
if (AXObjectCache* cache = document().existingAXObjectCache())
cache->didShowMenuListPopup(menuList);
}
« no previous file with comments | « no previous file | third_party/WebKit/Source/web/ExternalPopupMenu.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698