Issue 16135004: Rename JS_CURRENT_ISOLATE to JS_CURRENT_ISOLATE_CONTEXT.

Issue 16135004: Rename JS_CURRENT_ISOLATE to JS_CURRENT_ISOLATE_CONTEXT. (Closed)

Created:
7 years, 6 months ago by ahe

Modified:
7 years, 6 months ago

Reviewers:
ngeoffray, kasperl

CC:
reviews_dartlang.org, ngeoffray, Johnni Winther, karlklose

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Rename JS_CURRENT_ISOLATE to JS_CURRENT_ISOLATE_CONTEXT. Then add JS_CURRENT_ISOLATE for accessing $. Also add an option for using a different name instead of $. BUG=http://dartbug.com/2265 R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=23391

Patch Set 1 #

Total comments: 2

Created: 7 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+109 lines, -59 lines)			Patch
M	dart/sdk/lib/_internal/compiler/implementation/apiimpl.dart	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/compiler.dart	View	2 chunks	+7 lines, -0 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/dart2js.dart	View	4 chunks	+16 lines, -2 lines	2 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	4 chunks	+23 lines, -22 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/foreign_helper.dart	View	5 chunks	+15 lines, -10 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart	View	3 chunks	+4 lines, -3 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart	View	3 chunks	+4 lines, -4 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/lib/mirrors_patch.dart	View	5 chunks	+12 lines, -7 lines	0 comments	Download
M	dart/sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	3 chunks	+15 lines, -4 lines	0 comments	Download
M	dart/tests/compiler/dart2js/class_codegen_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/interceptor_test.dart	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	dart/tests/compiler/dart2js/static_closure_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	dart/tests/compiler/dart2js/type_guard_unuser_test.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/16135004/diff/1/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart File dart/sdk/lib/_internal/compiler/implementation/dart2js.dart (right): https://codereview.chromium.org/16135004/diff/1/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart#newcode174 dart/sdk/lib/_internal/compiler/implementation/dart2js.dart:174: fail('Error: "$globalName" must match "\\\$[a-z]*"'); Why? We could ...

7 years, 6 months ago (2013-05-28 20:01:54 UTC) #2

ahe

Thank you, Nicolas! https://codereview.chromium.org/16135004/diff/1/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart File dart/sdk/lib/_internal/compiler/implementation/dart2js.dart (right): https://codereview.chromium.org/16135004/diff/1/dart/sdk/lib/_internal/compiler/implementation/dart2js.dart#newcode174 dart/sdk/lib/_internal/compiler/implementation/dart2js.dart:174: fail('Error: "$globalName" must match "\\\$[a-z]*"'); On ...

7 years, 6 months ago (2013-05-30 09:13:31 UTC) #3

ahe

7 years, 6 months ago (2013-05-30 10:23:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r23391 (presubmit successful).

Expand Messages | Collapse Messages