content/browser/background_sync/background_sync_manager.cc - Issue 1613053004: [Background Sync Cleanup] Remove mention of oneshot

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/background_sync/background_sync_manager.cc

Issue 1613053004: [Background Sync Cleanup] Remove mention of oneshot (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@purge_periodic

Patch Set: Nit Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/background_sync/background_sync_manager.h ('k') | content/browser/background_sync/background_sync_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/background_sync/background_sync_manager.cc

diff --git a/content/browser/background_sync/background_sync_manager.cc b/content/browser/background_sync/background_sync_manager.cc

index d596760706d62bf58d5f68afa65d7768c5f18e3f..0eccb7b5f496398d2a462687341cc789d4104b16 100644

--- a/content/browser/background_sync/background_sync_manager.cc

+++ b/content/browser/background_sync/background_sync_manager.cc

@@ -767,7 +767,7 @@ void BackgroundSyncManager::GetDataFromBackend(

callback);

}

-void BackgroundSyncManager::FireOneShotSync(

+void BackgroundSyncManager::DispatchSyncEvent(

BackgroundSyncRegistrationHandle::HandleId handle_id,

const scoped_refptr<ServiceWorkerVersion>& active_version,

BackgroundSyncEventLastChance last_chance,

@@ -777,7 +777,7 @@ void BackgroundSyncManager::FireOneShotSync(

if (active_version->running_status() != ServiceWorkerVersion::RUNNING) {

active_version->RunAfterStartWorker(

- base::Bind(&BackgroundSyncManager::FireOneShotSync,

+ base::Bind(&BackgroundSyncManager::DispatchSyncEvent,

weak_ptr_factory_.GetWeakPtr(), handle_id, active_version,

last_chance, callback),

callback);

@@ -1230,7 +1230,7 @@ void BackgroundSyncManager::FireReadyEventsDidFindRegistration(

service_worker_registration->pattern().GetOrigin(),

base::Bind(&BackgroundSyncMetrics::RecordEventStarted));

- FireOneShotSync(

+ DispatchSyncEvent(

handle_id, service_worker_registration->active_version(), last_chance,

base::Bind(&BackgroundSyncManager::EventComplete,

weak_ptr_factory_.GetWeakPtr(), service_worker_registration,