Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1612873002: Fix types in display_options.js (Closed)

Created:
4 years, 11 months ago by stevenjb
Modified:
4 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_576375_display2
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix types in display_options.js This adds and fixes some types in display_options.js, in preparation for re-factoring it to support multiple displays. BUG=576375 Committed: https://crrev.com/26e3461a0c2f6a1a6be9272af332421c775aa74c Cr-Commit-Position: refs/heads/master@{#370749}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -139 lines) Patch
M chrome/browser/resources/options/chromeos/display_options.js View 23 chunks +139 lines, -139 lines 1 comment Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
stevenjb
https://codereview.chromium.org/1612873002/diff/1/chrome/browser/resources/options/chromeos/display_options.js File chrome/browser/resources/options/chromeos/display_options.js (left): https://codereview.chromium.org/1612873002/diff/1/chrome/browser/resources/options/chromeos/display_options.js#oldcode109 chrome/browser/resources/options/chromeos/display_options.js:109: } Unused
4 years, 11 months ago (2016-01-21 03:56:17 UTC) #2
xiyuan
lgtm
4 years, 11 months ago (2016-01-21 16:13:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1612873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1612873002/1
4 years, 11 months ago (2016-01-21 18:30:55 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-21 19:36:20 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 19:37:40 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26e3461a0c2f6a1a6be9272af332421c775aa74c
Cr-Commit-Position: refs/heads/master@{#370749}

Powered by Google App Engine
This is Rietveld 408576698