Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1167)

Issue 1588843002: Update display_options.js to better match chrome.system.display (Closed)

Created:
4 years, 11 months ago by stevenjb
Modified:
4 years, 11 months ago
Reviewers:
xiyuan, oshima
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@issue_576375_display1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update display_options.js to better match chrome.system.display This will make the eventual transition to using the chrome.system.display extension API simpler. It also improves the closure typechecking of display_options.js. Specifically, in this CL: options.DisplayInfo.{x,y,width,height} -> options.DisplayInfo.bounds.{left,top,width,height} options.DisplayInfo.colorProfile -> options.DisplayInfo.colorProfileId options.DisplayInfo.orientation -> options.DisplayInfo.rotation BUG=576375 Committed: https://crrev.com/bf0cd209cddd658ed4c29490dad7fabe0ad53cde Cr-Commit-Position: refs/heads/master@{#370603}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+134 lines, -89 lines) Patch
M chrome/browser/resources/options/chromeos/display_options.js View 1 15 chunks +108 lines, -69 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/options/chromeos/display_options_handler.cc View 1 5 chunks +25 lines, -19 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (7 generated)
stevenjb
4 years, 11 months ago (2016-01-20 19:05:29 UTC) #3
oshima
c++ lgtm. I'm not a good reviewer for js code. xiyuan@, can you review js ...
4 years, 11 months ago (2016-01-20 19:24:00 UTC) #5
xiyuan
display_options.js LGTM
4 years, 11 months ago (2016-01-20 21:26:12 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1588843002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1588843002/40001
4 years, 11 months ago (2016-01-21 01:18:41 UTC) #9
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-21 03:19:41 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-21 03:20:53 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bf0cd209cddd658ed4c29490dad7fabe0ad53cde
Cr-Commit-Position: refs/heads/master@{#370603}

Powered by Google App Engine
This is Rietveld 408576698