Cleanup: Deprecate DriveFileSyncService::kServiceName

Cleanup: Deprecate DriveFileSyncService::kServiceName

Also deprecate service_name parameters everywhere in SyncFileSystem.

BUG=246123
TEST=unit_tests:Drive\*, content_unittests:SyncableFileSystemUtilTest
TBR=nhiroki@chromium.org, tzik@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203893

[kinuko, 2013-06-03 12:07:35]

This is a recut of tzik's http://crrev.com/16190005 but does more aggressive
removal of service name references. Can you take a look? (tzik@ if you already
have a similar change I can drop mine)

tzik: overall
nhiroki:  c/b/sync_file_system/drive/metadata_db_migration_util*
webkit/browser/fileapi/syncable/syncable_file_system_util*

[nhiroki, 2013-06-04 02:24:03]

lgtm for
- c/b/sync_file_system/drive/metadata_db_migration_util*
- w/b/fileapi/syncable/syncable_file_system_util*

https://codereview.chromium.org/16109008/diff/6002/webkit/browser/fileapi/syn...
File webkit/browser/fileapi/syncable/syncable_file_system_util_unittest.cc
(right):

https://codereview.chromium.org/16109008/diff/6002/webkit/browser/fileapi/syn...
webkit/browser/fileapi/syncable/syncable_file_system_util_unittest.cc:154:
GURL("http://foo.com")).spec();
nit: Since "{foo,bar}.com" are external real domains, how about using
"{foo,bar}.example.com" instead?

[tzik, 2013-06-04 02:26:55]

lgtm

[commit-bot: I haz the power, 2013-06-04 02:35:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/16109008/6002

[commit-bot: I haz the power, 2013-06-04 02:49:48]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[kinuko, 2013-06-04 03:13:32]

TBR-ing yoyo for c/b/e/api/developer_private_api (it's a revised version of
https://codereview.chromium.org/16190005)

[commit-bot: I haz the power, 2013-06-04 03:13:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinuko@chromium.org/16109008/6002

[kinuko, 2013-06-04 07:24:05]

Committed patchset #1 manually as r203893 (presubmit successful).