Cleanup: Deprecate DriveFileSyncService::kServiceName

chrome/browser/sync_file_system/drive/metadata_db_migration_util_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync_file_system/drive/metadata_db_migration_util.h"
 
 #include "base/files/scoped_temp_dir.h"
 #include "base/string_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/sync_file_system/drive_metadata_store.h"
 #include "googleurl/src/gurl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 #include "third_party/leveldatabase/src/include/leveldb/db.h"
 #include "third_party/leveldatabase/src/include/leveldb/write_batch.h"
+#include "webkit/browser/fileapi/external_mount_points.h"
 #include "webkit/browser/fileapi/syncable/syncable_file_system_util.h"
 #include "webkit/common/fileapi/file_system_util.h"
 
 #define FPL FILE_PATH_LITERAL
 
 namespace sync_file_system {
 namespace drive {
 
 namespace {
+
 const char kV0ServiceName[] = "drive";
+
+bool CreateV0SerializedSyncableFileSystemURL(
+    const GURL& origin,
+    const base::FilePath& path,
+    std::string* serialized_url) {
+  fileapi::ScopedExternalFileSystem scoped_fs(
+      kV0ServiceName, fileapi::kFileSystemTypeSyncable, base::FilePath());
+
+  fileapi::FileSystemURL url =
+      fileapi::ExternalMountPoints::GetSystemInstance()->
+          CreateExternalFileSystemURL(origin, kV0ServiceName, path);
+  if (!url.is_valid())
+    return false;
+  *serialized_url = fileapi::GetExternalFileSystemRootURIString(
+        origin, kV0ServiceName) + url.path().AsUTF8Unsafe();
+  return true;
 }
 
+}  // namespace
+
 TEST(DriveMetadataDBMigrationUtilTest, ParseV0FormatFileSystemURL) {
   const GURL kOrigin("chrome-extension://example");
   const base::FilePath kFile(FPL("foo bar"));
 
-  ASSERT_TRUE(RegisterSyncableFileSystem(kV0ServiceName));
-
-  fileapi::FileSystemURL url =
-      CreateSyncableFileSystemURL(kOrigin, kV0ServiceName, kFile);
-
   std::string serialized_url;
-  SerializeSyncableFileSystemURL(url, &serialized_url);
+  ASSERT_TRUE(CreateV0SerializedSyncableFileSystemURL(
+      kOrigin, kFile, &serialized_url));
 
   GURL origin;
   base::FilePath path;
   EXPECT_TRUE(ParseV0FormatFileSystemURL(GURL(serialized_url), &origin, &path));
   EXPECT_EQ(kOrigin, origin);
   EXPECT_EQ(kFile, path);
-
-  EXPECT_TRUE(RevokeSyncableFileSystem(kV0ServiceName));
 }
 
 TEST(DriveMetadataDBMigrationUtilTest, AddWapiIdPrefix) {
   DriveMetadata_ResourceType type_file =
       DriveMetadata_ResourceType_RESOURCE_TYPE_FILE;
   DriveMetadata_ResourceType type_folder =
       DriveMetadata_ResourceType_RESOURCE_TYPE_FOLDER;
 
   EXPECT_EQ("file:xxx", AddWapiFilePrefix("xxx"));
   EXPECT_EQ("folder:yyy", AddWapiFolderPrefix("yyy"));
@@ skipping 25 matching lines @@
 
   const GURL kOrigin1("chrome-extension://example1");
   const GURL kOrigin2("chrome-extension://example2");
   const std::string kSyncRootResourceId("folder:sync_root_resource_id");
   const std::string kResourceId1("folder:hoge");
   const std::string kResourceId2("folder:fuga");
   const std::string kFileResourceId("file:piyo");
   const base::FilePath kFile(FPL("foo bar"));
   const std::string kFileMD5("file_md5");
 
-  ASSERT_TRUE(RegisterSyncableFileSystem(kV0ServiceName));
-
   base::ScopedTempDir base_dir;
   ASSERT_TRUE(base_dir.CreateUniqueTempDir());
 
   leveldb::Options options;
   options.create_if_missing = true;
   leveldb::DB* db_ptr = NULL;
   std::string db_dir = fileapi::FilePathToString(
       base_dir.path().Append(DriveMetadataStore::kDatabaseName));
   leveldb::Status status = leveldb::DB::Open(options, db_dir, &db_ptr);
 
   scoped_ptr<leveldb::DB> db(db_ptr);
   ASSERT_TRUE(status.ok());
 
   // Setup the database with the schema version 0.
   leveldb::WriteBatch batch;
   batch.Put(kChangeStampKey, "1");
   batch.Put(kSyncRootDirectoryKey, kSyncRootResourceId);
 
-  fileapi::FileSystemURL url =
-      CreateSyncableFileSystemURL(kOrigin1, kV0ServiceName, kFile);
-
   // Setup drive metadata.
   DriveMetadata drive_metadata;
   drive_metadata.set_resource_id(kFileResourceId);
   drive_metadata.set_md5_checksum(kFileMD5);
   drive_metadata.set_conflicted(false);
   drive_metadata.set_to_be_fetched(false);
 
   std::string serialized_url;
-  SerializeSyncableFileSystemURL(url, &serialized_url);
+  ASSERT_TRUE(CreateV0SerializedSyncableFileSystemURL(
+      kOrigin1, kFile, &serialized_url));
   std::string metadata_string;
   drive_metadata.SerializeToString(&metadata_string);
   batch.Put(kDriveMetadataKeyPrefix + serialized_url, metadata_string);
 
   // Setup batch sync origin and incremental sync origin.
   batch.Put(kDriveBatchSyncOriginKeyPrefix + kOrigin1.spec(), kResourceId1);
   batch.Put(kDriveIncrementalSyncOriginKeyPrefix + kOrigin2.spec(),
             kResourceId2);
 
   status = db->Write(leveldb::WriteOptions(), &batch);
   EXPECT_EQ(SYNC_STATUS_OK, LevelDBStatusToSyncStatusCode(status));
-  EXPECT_TRUE(RevokeSyncableFileSystem(kV0ServiceName));
 
   // Migrate the database.
   drive::MigrateDatabaseFromV0ToV1(db.get());
 
   scoped_ptr<leveldb::Iterator> itr(db->NewIterator(leveldb::ReadOptions()));
 
   // Verify DB schema version.
   int64 database_version = 0;
   itr->Seek(kDatabaseVersionKey);
   EXPECT_TRUE(itr->Valid());
@@ skipping 48 matching lines @@
   const GURL kOrigin3("chrome-extension://example3");
 
   const std::string kSyncRootResourceId("folder:sync_root_resource_id");
   const std::string kResourceId1("folder:hoge");
   const std::string kResourceId2("folder:fuga");
   const std::string kResourceId3("folder:hogera");
   const std::string kFileResourceId("file:piyo");
   const base::FilePath kFile(FPL("foo bar"));
   const std::string kFileMD5("file_md5");
 
-  const char kV1ServiceName[] = "syncfs";
-  ASSERT_TRUE(RegisterSyncableFileSystem(kV1ServiceName));
+  RegisterSyncableFileSystem();
 
   base::ScopedTempDir base_dir;
   ASSERT_TRUE(base_dir.CreateUniqueTempDir());
 
   leveldb::Options options;
   options.create_if_missing = true;
   leveldb::DB* db_ptr = NULL;
   std::string db_dir = fileapi::FilePathToString(
       base_dir.path().Append(DriveMetadataStore::kDatabaseName));
   leveldb::Status status = leveldb::DB::Open(options, db_dir, &db_ptr);
 
   scoped_ptr<leveldb::DB> db(db_ptr);
   ASSERT_TRUE(status.ok());
 
   // Setup the database with the schema version 1.
   leveldb::WriteBatch batch;
   batch.Put(kDatabaseVersionKey, "1");
   batch.Put(kChangeStampKey, "1");
   batch.Put(kSyncRootDirectoryKey, kSyncRootResourceId);
 
-  fileapi::FileSystemURL url =
-      CreateSyncableFileSystemURL(kOrigin1, kV1ServiceName, kFile);
+  fileapi::FileSystemURL url = CreateSyncableFileSystemURL(kOrigin1, kFile);
 
   // Setup drive metadata.
   DriveMetadata drive_metadata;
   drive_metadata.set_resource_id(kFileResourceId);
   drive_metadata.set_md5_checksum(kFileMD5);
   drive_metadata.set_conflicted(false);
   drive_metadata.set_to_be_fetched(false);
   std::string metadata_string;
   drive_metadata.SerializeToString(&metadata_string);
   std::string metadata_key = kDriveMetadataKeyPrefix + kOrigin1.spec() +
                              kMetadataKeySeparator + url.path().AsUTF8Unsafe();
   batch.Put(metadata_key, metadata_string);
 
   // Setup origins.
   batch.Put(kDriveBatchSyncOriginKeyPrefix + kOrigin1.spec(), kResourceId1);
   batch.Put(kDriveIncrementalSyncOriginKeyPrefix + kOrigin2.spec(),
             kResourceId2);
   batch.Put(kDriveDisabledOriginKeyPrefix + kOrigin3.spec(), kResourceId3);
 
   status = db->Write(leveldb::WriteOptions(), &batch);
   EXPECT_EQ(SYNC_STATUS_OK, LevelDBStatusToSyncStatusCode(status));
-  EXPECT_TRUE(RevokeSyncableFileSystem(kV1ServiceName));
+
+  RevokeSyncableFileSystem();
 
   // Migrate the database.
   drive::MigrateDatabaseFromV1ToV2(db.get());
 
   scoped_ptr<leveldb::Iterator> itr(db->NewIterator(leveldb::ReadOptions()));
 
   // Verify DB schema version.
   int64 database_version = 0;
   itr->Seek(kDatabaseVersionKey);
   EXPECT_TRUE(itr->Valid());
@@ skipping 33 matching lines @@
   EXPECT_EQ(RemoveWapiIdPrefix(kResourceId2), itr->value().ToString());
 
   // Verify the disabled origin.
   itr->Seek(kDriveDisabledOriginKeyPrefix);
   EXPECT_TRUE(itr->Valid());
   EXPECT_EQ(RemoveWapiIdPrefix(kResourceId3), itr->value().ToString());
 }
 
 }  // namespace drive
 }  // namespace sync_file_system