Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 16190005: [SyncFileSystem] Stop referring to DriveFileSyncService from extension/ (Closed)

Created:
7 years, 6 months ago by tzik
Modified:
7 years, 6 months ago
Reviewers:
kinuko, calvinlo, Yoyo Zhou
CC:
chromium-reviews, tzik+watch_chromium.org, Aaron Boodman, kinuko+watch, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

[SyncFileSystem] Stop referring to DriveFileSyncService from extension/. Adding SyncFileSystem::GetDefaultServiceName to break dependency from extension/ to DriveFileSyncService. BUG=244775

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -17 lines) Patch
M chrome/browser/extensions/api/developer_private/developer_private_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 4 chunks +10 lines, -12 lines 2 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_apitest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
tzik
DriveFileSyncService is originally a pluggable subsystem of SyncFileSystem. So, I'd keep extension APIs independent from ...
7 years, 6 months ago (2013-05-29 12:20:48 UTC) #1
kinuko
https://codereview.chromium.org/16190005/diff/1/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc File chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc (right): https://codereview.chromium.org/16190005/diff/1/chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc#newcode58 chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc:58: sync_file_system::SyncFileSystemService::GetDefaultServiceName()); I think this parameter can be dropped. (Not ...
7 years, 6 months ago (2013-05-29 14:12:20 UTC) #2
Yoyo Zhou
developer_private_api LGTM
7 years, 6 months ago (2013-05-29 18:00:26 UTC) #3
calvinlo
7 years, 6 months ago (2013-05-30 05:04:55 UTC) #4
lgtm after Kinuko comments addressed

Powered by Google App Engine
This is Rietveld 408576698