Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: src/gpu/glsl/GrGLSLShaderVar.h

Issue 1610853002: Add ability to add general layout qualifiers GrGLSLShaderVar (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: review update Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/glsl/GrGLSLShaderVar.h
diff --git a/src/gpu/glsl/GrGLSLShaderVar.h b/src/gpu/glsl/GrGLSLShaderVar.h
index a8b2c9b638cfb2455082375089dafece8fb57e3c..a8a9a47ba203a12e1991f98a8a553e093f52d5fd 100644
--- a/src/gpu/glsl/GrGLSLShaderVar.h
+++ b/src/gpu/glsl/GrGLSLShaderVar.h
@@ -20,43 +20,30 @@
class GrGLSLShaderVar : public GrShaderVar {
public:
/**
- * See GL_ARB_fragment_coord_conventions.
- */
- enum Origin {
- kDefault_Origin, // when set to kDefault the origin field is ignored.
- kUpperLeft_Origin, // only used to declare vec4 in gl_FragCoord.
- };
-
- /**
* Defaults to a float with no precision specifier
*/
GrGLSLShaderVar()
: GrShaderVar()
- , fOrigin(kDefault_Origin)
, fUseUniformFloatArrays(USE_UNIFORM_FLOAT_ARRAYS) {
}
GrGLSLShaderVar(const char* name, GrSLType type, int arrayCount = kNonArray,
GrSLPrecision precision = kDefault_GrSLPrecision)
: GrShaderVar(name, type, arrayCount, precision)
- , fOrigin(kDefault_Origin)
, fUseUniformFloatArrays(USE_UNIFORM_FLOAT_ARRAYS) {
SkASSERT(kVoid_GrSLType != type);
- fOrigin = kDefault_Origin;
fUseUniformFloatArrays = USE_UNIFORM_FLOAT_ARRAYS;
}
GrGLSLShaderVar(const char* name, GrSLType type, TypeModifier typeModifier,
int arrayCount = kNonArray, GrSLPrecision precision = kDefault_GrSLPrecision)
: GrShaderVar(name, type, typeModifier, arrayCount, precision)
- , fOrigin(kDefault_Origin)
, fUseUniformFloatArrays(USE_UNIFORM_FLOAT_ARRAYS) {
SkASSERT(kVoid_GrSLType != type);
}
GrGLSLShaderVar(const GrShaderVar& var)
: GrShaderVar(var)
- , fOrigin(kDefault_Origin)
, fUseUniformFloatArrays(USE_UNIFORM_FLOAT_ARRAYS) {
SkASSERT(kVoid_GrSLType != var.getType());
}
@@ -64,7 +51,6 @@ public:
GrGLSLShaderVar(const GrGLSLShaderVar& var)
: GrShaderVar(var.c_str(), var.getType(), var.getTypeModifier(),
var.getArrayCount(), var.getPrecision())
- , fOrigin(var.fOrigin)
, fUseUniformFloatArrays(var.fUseUniformFloatArrays) {
SkASSERT(kVoid_GrSLType != var.getType());
}
@@ -84,12 +70,12 @@ public:
TypeModifier typeModifier,
const SkString& name,
GrSLPrecision precision = kDefault_GrSLPrecision,
- Origin origin = kDefault_Origin,
+ const char* layoutQualifier = nullptr,
bool useUniformFloatArrays = USE_UNIFORM_FLOAT_ARRAYS) {
SkASSERT(kVoid_GrSLType != type);
SkASSERT(kDefault_GrSLPrecision == precision || GrSLTypeIsFloatType(type));
INHERITED::set(type, name, typeModifier, precision);
- fOrigin = origin;
+ fLayoutQualifier = layoutQualifier;
fUseUniformFloatArrays = useUniformFloatArrays;
}
@@ -100,12 +86,12 @@ public:
TypeModifier typeModifier,
const char* name,
GrSLPrecision precision = kDefault_GrSLPrecision,
- Origin origin = kDefault_Origin,
+ const char* layoutQualifier = nullptr,
bool useUniformFloatArrays = USE_UNIFORM_FLOAT_ARRAYS) {
SkASSERT(kVoid_GrSLType != type);
SkASSERT(kDefault_GrSLPrecision == precision || GrSLTypeIsFloatType(type));
INHERITED::set(type, name, typeModifier, precision);
- fOrigin = origin;
+ fLayoutQualifier = layoutQualifier;
fUseUniformFloatArrays = useUniformFloatArrays;
}
@@ -117,12 +103,12 @@ public:
const SkString& name,
int count,
GrSLPrecision precision = kDefault_GrSLPrecision,
- Origin origin = kDefault_Origin,
+ const char* layoutQualifier = nullptr,
bool useUniformFloatArrays = USE_UNIFORM_FLOAT_ARRAYS) {
SkASSERT(kVoid_GrSLType != type);
SkASSERT(kDefault_GrSLPrecision == precision || GrSLTypeIsFloatType(type));
INHERITED::set(type, name, typeModifier, precision, count);
- fOrigin = origin;
+ fLayoutQualifier = layoutQualifier;
fUseUniformFloatArrays = useUniformFloatArrays;
}
@@ -134,34 +120,22 @@ public:
const char* name,
int count,
GrSLPrecision precision = kDefault_GrSLPrecision,
- Origin origin = kDefault_Origin,
+ const char* layoutQualifier = nullptr,
bool useUniformFloatArrays = USE_UNIFORM_FLOAT_ARRAYS) {
SkASSERT(kVoid_GrSLType != type);
SkASSERT(kDefault_GrSLPrecision == precision || GrSLTypeIsFloatType(type));
INHERITED::set(type, name, typeModifier, precision, count);
- fOrigin = origin;
+ fLayoutQualifier = layoutQualifier;
fUseUniformFloatArrays = useUniformFloatArrays;
}
/**
- * Get the origin of the var
- */
- Origin getOrigin() const { return fOrigin; }
-
- /**
- * Set the origin of the var
- */
- void setOrigin(Origin origin) { fOrigin = origin; }
-
- /**
* Write a declaration of this variable to out.
*/
void appendDecl(const GrGLSLCaps* glslCaps, SkString* out) const {
SkASSERT(kDefault_GrSLPrecision == fPrecision || GrSLTypeIsFloatType(fType));
- if (kUpperLeft_Origin == fOrigin) {
- // this is the only place where we specify a layout modifier. If we use other layout
- // modifiers in the future then they should be placed in a list.
- out->append("layout(origin_upper_left) ");
+ if (!fLayoutQualifier.isEmpty()) {
+ out->appendf("layout(%s) ", fLayoutQualifier.c_str());
}
if (this->getTypeModifier() != kNone_TypeModifier) {
out->append(TypeModifierString(glslCaps, this->getTypeModifier()));
@@ -245,11 +219,12 @@ private:
}
}
- Origin fOrigin;
/// Work around driver bugs on some hardware that don't correctly
/// support uniform float []
bool fUseUniformFloatArrays;
+ SkString fLayoutQualifier;
+
typedef GrShaderVar INHERITED;
};
« no previous file with comments | « src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698