Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

default_host was moved into LoginDisplayHost in https://codereview.chromium.org/1539713002.

BUG=580637
Committed: https://crrev.com/314f069209f0658cbfa61fd4dd1dd20795a2dbe2
Cr-Commit-Position: refs/heads/master@{#371127}

[jdufault, 2016-01-20 23:41:49]

jdufault@chromium.org changed reviewers:
+ achuith@chromium.org, dzhioev@chromium.org

[jdufault, 2016-01-20 23:41:50]

Pavel / Achuith, PTAL. This is a simple refactor to call default_host from
LoginDisplayHost instead of LoginDisplayHostImpl. See the parent CL which moves
display_host into LoginDisplayHost. This CL just updates invocation sites.

I also moved GetOobeUI into LoginDisplayHost, which removed a fair number of
casts.

There are some additional header file includes due to violations of the IWYU
rule.

[achuithb, 2016-01-21 23:14:31]

Could you please reference the parent CL in this CL's description?

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/kiosk_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/kiosk_browsertest.cc:793: return
chromeos::LoginDisplayHost::default_host()->GetAppLaunchController();
Drop chromeos:: here and below

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc:75: OobeUI*
oobe_ui = chromeos::LoginDisplayHost::default_host()->GetOobeUI();
Don't need chromeos::

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/oobe_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/oobe_browsertest.cc:63: return
static_cast<chromeos::LoginDisplayHostImpl*>(
Is this static_cast necessary?

Drop chromeos::

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/oobe_localization_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/oobe_localization_browsertest.cc:328:
chromeos::LoginDisplayHost::default_host()
Drop chromeos:: here and below

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/test/oobe_base_test.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/test/oobe_base_test.cc:204: return
chromeos::LoginDisplayHost::default_host()->GetOobeUI()->web_ui();
drop chromeos::

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/test/oobe_screen_waiter.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/test/oobe_screen_waiter.cc:53: OobeUI* oobe_ui =
chromeos::LoginDisplayHost::default_host()->GetOobeUI();
drop chromeos::

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
(right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc:86:
LoginDisplayHost::default_host()->GetWebUILoginView()->GetWebContents();
use host_?

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc:123:
EXPECT_TRUE(LoginDisplayHost::default_host() == NULL);
nullptr since you're here

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc:159:
EXPECT_TRUE(LoginDisplayHost::default_host() == NULL);
nullptr

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/webui_login_display.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/webui_login_display.cc:101:
chromeos::LoginDisplayHost::default_host()) {
drop chromeos::

Pull the assignment out of the if stmt please while you're here

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
(right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc:379:
chromeos::LoginDisplayHost::default_host()
drop chromeos::

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/opt...
File chrome/browser/chromeos/options/network_config_view.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/opt...
chrome/browser/chromeos/options/network_config_view.cc:46: if
(chromeos::LoginDisplayHost::default_host()) {
move the anon namespace to within chromeos namespace and drop chromeos::

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/sys...
File chrome/browser/chromeos/system/device_disabling_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/sys...
chrome/browser/chromeos/system/device_disabling_browsertest.cc:178: const
LoginDisplayHost* const host = LoginDisplayHost::default_host();
Maybe drop all the consts here?

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc:176: if
(LoginDisplayHost::default_host()) {
Ugh, we should drop this if stmt. It's fine if you don't want to do it in this
CL

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc:87: gfx::NativeWindow
parent = NULL;
nullptr since you're here

[dzhioev (left Google), 2016-01-21 23:25:04]

LGTM

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/webui_login_display.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/webui_login_display.cc:101:
chromeos::LoginDisplayHost::default_host()) {
On 2016/01/21 23:14:31, achuithb wrote:
> drop chromeos::
> 
> Pull the assignment out of the if stmt please while you're here

Hmm, what's wrong with the assignment?

[achuithb, 2016-01-21 23:33:53]

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/webui_login_display.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/webui_login_display.cc:101:
chromeos::LoginDisplayHost::default_host()) {
On 2016/01/21 23:25:04, dzhioev wrote:
> On 2016/01/21 23:14:31, achuithb wrote:
> > drop chromeos::
> > 
> > Pull the assignment out of the if stmt please while you're here
> 
> Hmm, what's wrong with the assignment?

Is this normal? The pattern I'm familiar with is:
LoginDisplayHost* host = LoginDisplayHost::default_host();
if (host) {
...

Is it stylistically ok to have an assignment as a condition in an if stmt? I'm
not able to find anything in the style guide that forbids this, so maybe it's
ok, but this is the first time I'm seeing this in the chromium code base.

[dzhioev (left Google), 2016-01-22 00:14:47]

On 2016/01/21 23:33:53, achuithb wrote:
>
https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
> File chrome/browser/chromeos/login/ui/webui_login_display.cc (right):
> 
>
https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
> chrome/browser/chromeos/login/ui/webui_login_display.cc:101:
> chromeos::LoginDisplayHost::default_host()) {
> On 2016/01/21 23:25:04, dzhioev wrote:
> > On 2016/01/21 23:14:31, achuithb wrote:
> > > drop chromeos::
> > > 
> > > Pull the assignment out of the if stmt please while you're here
> > 
> > Hmm, what's wrong with the assignment?
> 
> Is this normal? The pattern I'm familiar with is:
> LoginDisplayHost* host = LoginDisplayHost::default_host();
> if (host) {
> ...
> 
> Is it stylistically ok to have an assignment as a condition in an if stmt? I'm
> not able to find anything in the style guide that forbids this, so maybe it's
> ok, but this is the first time I'm seeing this in the chromium code base.

Such a construction is perfectly correct and standard. Probably not so many
people know about it.

[dzhioev (left Google), 2016-01-22 00:15:09]

On 2016/01/22 00:14:47, dzhioev wrote:
> On 2016/01/21 23:33:53, achuithb wrote:
> >
>
https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
> > File chrome/browser/chromeos/login/ui/webui_login_display.cc (right):
> > 
> >
>
https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
> > chrome/browser/chromeos/login/ui/webui_login_display.cc:101:
> > chromeos::LoginDisplayHost::default_host()) {
> > On 2016/01/21 23:25:04, dzhioev wrote:
> > > On 2016/01/21 23:14:31, achuithb wrote:
> > > > drop chromeos::
> > > > 
> > > > Pull the assignment out of the if stmt please while you're here
> > > 
> > > Hmm, what's wrong with the assignment?
> > 
> > Is this normal? The pattern I'm familiar with is:
> > LoginDisplayHost* host = LoginDisplayHost::default_host();
> > if (host) {
> > ...
> > 
> > Is it stylistically ok to have an assignment as a condition in an if stmt?
I'm
> > not able to find anything in the style guide that forbids this, so maybe
it's
> > ok, but this is the first time I'm seeing this in the chromium code base.
> 
> Such a construction is perfectly correct and standard. Probably not so many
> people know about it.

I'm the author of this code BTW =)

[jdufault, 2016-01-22 19:43:20]

Description was changed from

==========
Move LoginDisplayHostImpl::default_host into LoginDisplayHost.

BUG=532545
==========

to

==========
Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

default_host was moved into LoginDisplayHost in
https://codereview.chromium.org/1539713002.

BUG=580637
==========

[jdufault, 2016-01-22 21:14:11]

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/kiosk_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/kiosk_browsertest.cc:793: return
chromeos::LoginDisplayHost::default_host()->GetAppLaunchController();
On 2016/01/21 23:14:31, achuithb wrote:
> Drop chromeos:: here and below

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc:75: OobeUI*
oobe_ui = chromeos::LoginDisplayHost::default_host()->GetOobeUI();
On 2016/01/21 23:14:31, achuithb wrote:
> Don't need chromeos::

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/oobe_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/oobe_browsertest.cc:63: return
static_cast<chromeos::LoginDisplayHostImpl*>(
On 2016/01/21 23:14:31, achuithb wrote:
> Is this static_cast necessary?
> 
> Drop chromeos::

Yep, the cast is needed.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/oobe_localization_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/oobe_localization_browsertest.cc:328:
chromeos::LoginDisplayHost::default_host()
On 2016/01/21 23:14:31, achuithb wrote:
> Drop chromeos:: here and below

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/test/oobe_base_test.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/test/oobe_base_test.cc:204: return
chromeos::LoginDisplayHost::default_host()->GetOobeUI()->web_ui();
On 2016/01/21 23:14:31, achuithb wrote:
> drop chromeos::

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/test/oobe_screen_waiter.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/test/oobe_screen_waiter.cc:53: OobeUI* oobe_ui =
chromeos::LoginDisplayHost::default_host()->GetOobeUI();
On 2016/01/21 23:14:31, achuithb wrote:
> drop chromeos::

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
(right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc:86:
LoginDisplayHost::default_host()->GetWebUILoginView()->GetWebContents();
On 2016/01/21 23:14:31, achuithb wrote:
> use host_?

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc:123:
EXPECT_TRUE(LoginDisplayHost::default_host() == NULL);
On 2016/01/21 23:14:31, achuithb wrote:
> nullptr since you're here

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/user_adding_screen_browsertest.cc:159:
EXPECT_TRUE(LoginDisplayHost::default_host() == NULL);
On 2016/01/21 23:14:31, achuithb wrote:
> nullptr

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/webui_login_display.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/webui_login_display.cc:101:
chromeos::LoginDisplayHost::default_host()) {
On 2016/01/21 23:33:53, achuithb wrote:
> On 2016/01/21 23:25:04, dzhioev wrote:
> > On 2016/01/21 23:14:31, achuithb wrote:
> > > drop chromeos::
> > > 
> > > Pull the assignment out of the if stmt please while you're here
> > 
> > Hmm, what's wrong with the assignment?
> 
> Is this normal? The pattern I'm familiar with is:
> LoginDisplayHost* host = LoginDisplayHost::default_host();
> if (host) {
> ...
> 
> Is it stylistically ok to have an assignment as a condition in an if stmt? I'm
> not able to find anything in the style guide that forbids this, so maybe it's
> ok, but this is the first time I'm seeing this in the chromium code base.

I've reworked this to avoid the nested if. It also removes the assignment inside
the if.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc
(right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager_policy_browsertest.cc:379:
chromeos::LoginDisplayHost::default_host()
On 2016/01/21 23:14:31, achuithb wrote:
> drop chromeos::

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/opt...
File chrome/browser/chromeos/options/network_config_view.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/opt...
chrome/browser/chromeos/options/network_config_view.cc:46: if
(chromeos::LoginDisplayHost::default_host()) {
On 2016/01/21 23:14:31, achuithb wrote:
> move the anon namespace to within chromeos namespace and drop chromeos::

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/sys...
File chrome/browser/chromeos/system/device_disabling_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/sys...
chrome/browser/chromeos/system/device_disabling_browsertest.cc:178: const
LoginDisplayHost* const host = LoginDisplayHost::default_host();
On 2016/01/21 23:14:31, achuithb wrote:
> Maybe drop all the consts here?

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc:176: if
(LoginDisplayHost::default_host()) {
On 2016/01/21 23:14:31, achuithb wrote:
> Ugh, we should drop this if stmt. It's fine if you don't want to do it in this
> CL

Done.

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/ui/webui/chr...
File chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/ui/webui/chr...
chrome/browser/ui/webui/chromeos/mobile_setup_dialog.cc:87: gfx::NativeWindow
parent = NULL;
On 2016/01/21 23:14:31, achuithb wrote:
> nullptr since you're here

Done.

[achuithb, 2016-01-22 22:37:08]

Thank you for taking care of the nits.

LGTM!

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/ui/webui_login_display.cc (right):

https://codereview.chromium.org/1610823003/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/ui/webui_login_display.cc:101:
chromeos::LoginDisplayHost::default_host()) {
On 2016/01/22 21:14:11, jdufault wrote:
> On 2016/01/21 23:33:53, achuithb wrote:
> > On 2016/01/21 23:25:04, dzhioev wrote:
> > > On 2016/01/21 23:14:31, achuithb wrote:
> > > > drop chromeos::
> > > > 
> > > > Pull the assignment out of the if stmt please while you're here
> > > 
> > > Hmm, what's wrong with the assignment?
> > 
> > Is this normal? The pattern I'm familiar with is:
> > LoginDisplayHost* host = LoginDisplayHost::default_host();
> > if (host) {
> > ...
> > 
> > Is it stylistically ok to have an assignment as a condition in an if stmt?
I'm
> > not able to find anything in the style guide that forbids this, so maybe
it's
> > ok, but this is the first time I'm seeing this in the chromium code base.
> 
> I've reworked this to avoid the nested if. It also removes the assignment
inside
> the if.

Thank you! This is more concise and familiar.

https://codereview.chromium.org/1610823003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/oobe_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/oobe_browsertest.cc:57: CHECK(controller);
nit: drop check since line below crashes

https://codereview.chromium.org/1610823003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
(right):

https://codereview.chromium.org/1610823003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc:84:
CHECK(host_);
nit: drop CHECK since line below crashes

[jdufault, 2016-01-22 23:04:15]

https://codereview.chromium.org/1610823003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/oobe_browsertest.cc (right):

https://codereview.chromium.org/1610823003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/oobe_browsertest.cc:57: CHECK(controller);
On 2016/01/22 22:37:08, achuithb wrote:
> nit: drop check since line below crashes

Done.

https://codereview.chromium.org/1610823003/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
(right):

https://codereview.chromium.org/1610823003/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc:84:
CHECK(host_);
On 2016/01/22 22:37:08, achuithb wrote:
> nit: drop CHECK since line below crashes

Done.

[jdufault, 2016-01-22 23:05:40]

jdufault@chromium.org changed reviewers:
+ stevenjb@chromium.org

[jdufault, 2016-01-22 23:05:41]

Steven please take a look at
chrome/browser/ui/ash/system_tray_delegate_chromeos.cc, need owner LGTM.

Thanks!

[stevenjb, 2016-01-22 23:17:11]

c/b/ui/ash lgtm

[jdufault, 2016-01-23 00:00:31]

The CQ bit was checked by jdufault@chromium.org

[jdufault, 2016-01-23 00:00:31]

The patchset sent to the CQ was uploaded after l-g-t-m from
dzhioev@chromium.org, achuith@chromium.org
Link to the patchset: https://codereview.chromium.org/1610823003/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-01-23 00:02:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610823003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610823003/40001

[commit-bot: I haz the power, 2016-01-23 00:39:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-23 00:39:14]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, no
build URL)

[tandrii(chromium), 2016-01-23 01:44:35]

On 2016/01/23 00:39:14, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, no
> build URL)

There was a problem with these builders. I've pressed CQ again.

[tandrii(chromium), 2016-01-23 01:44:37]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2016-01-23 01:45:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1610823003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1610823003/40001

[commit-bot: I haz the power, 2016-01-23 02:14:35]

Description was changed from

==========
Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

default_host was moved into LoginDisplayHost in
https://codereview.chromium.org/1539713002.

BUG=580637
==========

to

==========
Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

default_host was moved into LoginDisplayHost in
https://codereview.chromium.org/1539713002.

BUG=580637
==========

[commit-bot: I haz the power, 2016-01-23 02:14:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-23 02:15:51]

Description was changed from

==========
Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

default_host was moved into LoginDisplayHost in
https://codereview.chromium.org/1539713002.

BUG=580637
==========

to

==========
Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

default_host was moved into LoginDisplayHost in
https://codereview.chromium.org/1539713002.

BUG=580637

Committed: https://crrev.com/314f069209f0658cbfa61fd4dd1dd20795a2dbe2
Cr-Commit-Position: refs/heads/master@{#371127}
==========

[commit-bot: I haz the power, 2016-01-23 02:15:53]

Patchset 3 (id:??) landed as
https://crrev.com/314f069209f0658cbfa61fd4dd1dd20795a2dbe2
Cr-Commit-Position: refs/heads/master@{#371127}