Migrate call sites LoginDisplayHostImpl::default_host to LoginDisplayHost.

chrome/browser/chromeos/login/ui/webui_login_display.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/ui/webui_login_display.h"
 
 #include "chrome/browser/chromeos/accessibility/accessibility_manager.h"
 #include "chrome/browser/chromeos/login/lock/screen_locker.h"
 #include "chrome/browser/chromeos/login/screens/chrome_user_selection_screen.h"
 #include "chrome/browser/chromeos/login/signin_screen_controller.h"
 #include "chrome/browser/chromeos/login/startup_utils.h"
-#include "chrome/browser/chromeos/login/ui/login_display_host_impl.h"
+#include "chrome/browser/chromeos/login/ui/login_display_host.h"
 #include "chrome/browser/chromeos/login/ui/user_adding_screen.h"
 #include "chrome/browser/chromeos/login/ui/webui_login_view.h"
 #include "chrome/browser/chromeos/login/users/wallpaper/wallpaper_manager.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chromeos/login/user_names.h"
 #include "components/signin/core/account_id/account_id.h"
 #include "components/user_manager/user_manager.h"
@@ skipping 68 matching lines @@
   // see http://crbug.com/157885 and http://crbug.com/158255.
   // Allow this call only before user sign in or at lock screen.
   // If this call is made after new user signs in but login screen is still
   // around that would trigger a sign in extension refresh.
   if (is_enabled && (!user_manager::UserManager::Get()->IsUserLoggedIn() ||
                      ScreenLocker::default_screen_locker())) {
     ClearAndEnablePassword();
   }
 
   if (chromeos::LoginDisplayHost* host =
-          chromeos::LoginDisplayHostImpl::default_host()) {
+          chromeos::LoginDisplayHost::default_host()) {

[achuithb, 2016/01/21 23:14:31]

drop chromeos::

Pull the assignment out of the if stmt please while you're here

[dzhioev (left Google), 2016/01/21 23:25:04]

Hmm, what's wrong with the assignment?

[achuithb, 2016/01/21 23:33:53]

Is this normal? The pattern I'm familiar with is:
LoginDisplayHost* host = LoginDisplayHost::default_host();
if (host) {
...

Is it stylistically ok to have an assignment as a condition in an if stmt? I'm
not able to find anything in the style guide that forbids this, so maybe it's
ok, but this is the first time I'm seeing this in the chromium code base.

[jdufault, 2016/01/22 21:14:11]

I've reworked this to avoid the nested if. It also removes the assignment inside
the if.

[achuithb, 2016/01/22 22:37:08]

Thank you! This is more concise and familiar.

     if (chromeos::WebUILoginView* login_view = host->GetWebUILoginView())
       login_view->SetUIEnabled(is_enabled);
   }
 }
 
 void WebUILoginDisplay::ShowError(int error_msg_id,
                                   int login_attempts,
                                   HelpAppLauncher::HelpTopic help_topic_id) {
   VLOG(1) << "Show error, error_id: " << error_msg_id
           << ", attempts:" << login_attempts
@@ skipping 210 matching lines @@
 }
 
 bool WebUILoginDisplay::IsUserWhitelisted(const AccountId& account_id) {
   DCHECK(delegate_);
   if (delegate_)
     return delegate_->IsUserWhitelisted(account_id);
   return true;
 }
 
 }  // namespace chromeos