Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 1539713002: Move default_host from LoginDisplayHostImpl to LoginDisplayHost. (Closed)

Created:
5 years ago by jdufault
Modified:
4 years, 11 months ago
CC:
chromium-reviews, pam+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move default_host from LoginDisplayHostImpl to LoginDisplayHost. The call sites are moved in https://codereview.chromium.org/1610823003/. BUG=580637 Committed: https://crrev.com/75b5c2701d7d146aacc066610c8298987ca97f7f Cr-Commit-Position: refs/heads/master@{#371035}

Patch Set 1 #

Patch Set 2 : Hide bottom bar instead #

Patch Set 3 : Move GetOobeUI and default_host() into LoginDisplayHost #

Patch Set 4 : Fix test #

Total comments: 1

Patch Set 5 : Move supervised user changes to a dependent CL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M chrome/browser/chromeos/login/ui/login_display_host.h View 1 2 4 chunks +11 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/login/ui/login_display_host.cc View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.h View 1 2 4 chunks +1 line, -12 lines 0 comments Download
M chrome/browser/chromeos/login/ui/login_display_host_impl.cc View 1 2 3 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ui/mock_login_display_host.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (7 generated)
jdufault
Doesn't look like there is a good owner for this file anymore. PTAL Pavel or ...
5 years ago (2015-12-17 23:56:12 UTC) #3
dzhioev (left Google)
On 2015/12/17 23:56:12, jdufault wrote: > Doesn't look like there is a good owner for ...
5 years ago (2015-12-18 05:02:40 UTC) #4
jdufault
On 2015/12/18 05:02:40, dzhioev wrote: > Can't we just hide the shelf? It looks like ...
5 years ago (2015-12-18 18:13:20 UTC) #5
dzhioev (left Google)
On 2015/12/18 18:13:20, jdufault wrote: > On 2015/12/18 05:02:40, dzhioev wrote: > > Can't we ...
5 years ago (2015-12-19 01:16:45 UTC) #6
jdufault
On 2015/12/19 01:16:45, dzhioev wrote: > ... > Actually shelf's auto-hide behavior doesn't apply to ...
4 years, 11 months ago (2016-01-12 19:49:21 UTC) #7
dzhioev (left Google)
On 2016/01/12 19:49:21, jdufault wrote: > On 2015/12/19 01:16:45, dzhioev wrote: > > ... > ...
4 years, 11 months ago (2016-01-14 16:46:15 UTC) #8
jdufault
> > I can propagate GetOobeUI into LoginDisplayHost instead > > if that's preferable (and ...
4 years, 11 months ago (2016-01-20 01:21:44 UTC) #9
achuithb
I think it's better to split this into 2 CLs - one with LoginDisplayHost::default_host change, ...
4 years, 11 months ago (2016-01-21 23:13:06 UTC) #10
dzhioev (left Google)
On 2016/01/20 01:21:44, jdufault wrote: > > > I can propagate GetOobeUI into LoginDisplayHost instead ...
4 years, 11 months ago (2016-01-21 23:14:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1539713002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1539713002/80001
4 years, 11 months ago (2016-01-22 19:43:34 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 11 months ago (2016-01-22 21:04:35 UTC) #17
commit-bot: I haz the power
4 years, 11 months ago (2016-01-22 21:05:35 UTC) #19
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/75b5c2701d7d146aacc066610c8298987ca97f7f
Cr-Commit-Position: refs/heads/master@{#371035}

Powered by Google App Engine
This is Rietveld 408576698