Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1610823002: Consolidate SK_CRASH and sk_throw into SK_ABORT (Closed)

Created:
4 years, 11 months ago by djsollen
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : experiment #

Total comments: 1

Patch Set 3 : consolidate #

Patch Set 4 : bug fix #

Patch Set 5 : windows fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -78 lines) Patch
M bench/ChecksumBench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M bench/nanobench.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M gm/textblob.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/config/SkUserConfig.h View 1 2 1 chunk +0 lines, -7 lines 0 comments Download
M include/core/SkPostConfig.h View 1 2 chunks +12 lines, -33 lines 0 comments Download
M include/core/SkTArray.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypes.h View 1 2 3 3 chunks +7 lines, -3 lines 0 comments Download
M src/core/SkPath.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/core/SkRegionPriv.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/device/xps/SkXPSDevice.cpp View 1 2 3 4 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrAllocator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrTRecorder.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkFontMgr_win_dw.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkMemory_malloc.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M src/ports/SkMemory_mozalloc.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download
M src/ports/SkTypeface_win_dw.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/CachedDataTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsCubicLineIntersectionIdeas.cpp View 1 2 5 chunks +10 lines, -10 lines 0 comments Download
M tools/Stats.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tools/sk_tool_utils_font.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (14 generated)
djsollen
4 years, 11 months ago (2016-01-21 15:01:03 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610823002/1
4 years, 11 months ago (2016-01-21 15:01:17 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/5512)
4 years, 11 months ago (2016-01-21 15:03:41 UTC) #7
reed1
lgtm
4 years, 11 months ago (2016-01-21 15:08:34 UTC) #8
djsollen
I know the latest patch won't compile, but wanted to get your feedback on the ...
4 years, 11 months ago (2016-01-21 16:25:33 UTC) #9
reed1
https://codereview.chromium.org/1610823002/diff/20001/include/core/SkTypes.h File include/core/SkTypes.h (right): https://codereview.chromium.org/1610823002/diff/20001/include/core/SkTypes.h#newcode131 include/core/SkTypes.h:131: #define SkRELEASE_ASSERT(cond) if(cond) { SK_ABORT(cond); } I find passing ...
4 years, 11 months ago (2016-01-21 18:29:31 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610823002/40001
4 years, 11 months ago (2016-01-21 20:17:36 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Shared-Trybot/builds/5413)
4 years, 11 months ago (2016-01-21 20:19:33 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610823002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610823002/60001
4 years, 11 months ago (2016-01-21 20:27:57 UTC) #17
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/5538)
4 years, 11 months ago (2016-01-21 20:30:45 UTC) #19
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610823002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610823002/80001
4 years, 11 months ago (2016-01-21 20:35:46 UTC) #21
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-ShuttleA-GPU-GTX660-x86_64-Release-Trybot on client.skia (JOB_TIMED_OUT, no build URL)
4 years, 11 months ago (2016-01-21 22:36:03 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1610823002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1610823002/80001
4 years, 11 months ago (2016-01-22 14:04:02 UTC) #26
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/4c5cd7d527ed29aabfa72aa47b23a4496eeda357
4 years, 11 months ago (2016-01-22 14:05:01 UTC) #28
djsollen
4 years, 11 months ago (2016-01-22 14:50:05 UTC) #29
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1620333002/ by djsollen@google.com.

The reason for reverting is: Chrome is calling SK_CRASH.

Powered by Google App Engine
This is Rietveld 408576698