src/ports/SkTypeface_win_dw.cpp - Issue 1610823002: Consolidate SK_CRASH and sk_throw into SK_ABORT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ports/SkTypeface_win_dw.cpp

Issue 1610823002: Consolidate SK_CRASH and sk_throw into SK_ABORT (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: windows fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ports/SkTypeface_win_dw.cpp

diff --git a/src/ports/SkTypeface_win_dw.cpp b/src/ports/SkTypeface_win_dw.cpp

index 38d09e85ecf25a0aaeeef023a2f7d16495b5637c..160c66ed0eb577d10ea5bbf0f2dcd7366f711052 100644

--- a/src/ports/SkTypeface_win_dw.cpp

+++ b/src/ports/SkTypeface_win_dw.cpp

@@ -111,7 +111,7 @@ int DWriteFontTypeface::onCharsToGlyphs(const void* chars, Encoding encoding,

break;

}

default:

- SK_CRASH();

+ SK_ABORT("Invalid Text Encoding");

}

for (int i = 0; i < glyphCount; ++i) {

« no previous file with comments | « src/ports/SkTypeface_win_dw.h ('k') | tests/CachedDataTest.cpp » ('j') | no next file with comments »