bench/nanobench.cpp - Issue 1610823002: Consolidate SK_CRASH and sk_throw into SK_ABORT

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: bench/nanobench.cpp

Issue 1610823002: Consolidate SK_CRASH and sk_throw into SK_ABORT (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: windows fix Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: bench/nanobench.cpp

diff --git a/bench/nanobench.cpp b/bench/nanobench.cpp

index 7efd858c5cd5a8a0e761c399a839fa6964526e2b..15b16088793d297f62193efdeb4a10646841b2a0 100644

--- a/bench/nanobench.cpp

+++ b/bench/nanobench.cpp

@@ -947,7 +947,7 @@ public:

log->configOption("clip",

SkStringPrintf("%d %d %d %d", fClip.fLeft, fClip.fTop,

fClip.fRight, fClip.fBottom).c_str());

- SK_ALWAYSBREAK(fCurrentScale < fScales.count()); // debugging paranoia

+ SkASSERT_RELEASE(fCurrentScale < fScales.count()); // debugging paranoia

log->configOption("scale", SkStringPrintf("%.2g", fScales[fCurrentScale]).c_str());

if (fCurrentUseMPD > 0) {

SkASSERT(1 == fCurrentUseMPD || 2 == fCurrentUseMPD);

« no previous file with comments | « bench/ChecksumBench.cpp ('k') | gm/textblob.cpp » ('j') | no next file with comments »