Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3243)

Unified Diff: dart/tests/lib/mirrors/mirrors_test.dart

Issue 16097002: Implement simple name and qualified name. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/tests/lib/mirrors/mirrors_test.dart
diff --git a/dart/tests/lib/mirrors/mirrors_test.dart b/dart/tests/lib/mirrors/mirrors_test.dart
index 6bf6e8f89be222e4d0dc2cd8090166c3010ddad7..4c1d71fe695938d221d6e73bdac1099ee1b2349a 100644
--- a/dart/tests/lib/mirrors/mirrors_test.dart
+++ b/dart/tests/lib/mirrors/mirrors_test.dart
@@ -161,7 +161,7 @@ testReflectClass(mirrors) {
expect(objectMirror.reflectee.field, equals(1234));
}
-testNames(mirrors) {
+testNames(mirrors, isDart2js) {
var libMirror = mirrors.findLibrary(const Symbol("MirrorsTest")).single;
var classMirror = libMirror.classes[const Symbol('Class')];
var typedefMirror = libMirror.members[const Symbol('Typedef')];
@@ -174,14 +174,16 @@ testNames(mirrors) {
expect(classMirror.simpleName, equals(const Symbol('Class')));
expect(classMirror.qualifiedName, equals(const Symbol('MirrorsTest.Class')));
- TypeVariableMirror typeVariable = classMirror.typeVariables.values.single;
- expect(typeVariable.simpleName, equals(const Symbol('T')));
- expect(typeVariable.qualifiedName,
- equals(const Symbol('MirrorsTest.Class.T')));
+ if (!isDart2js) { // TODO(ahe): Implement this in dart2js.
+ TypeVariableMirror typeVariable = classMirror.typeVariables.values.single;
+ expect(typeVariable.simpleName, equals(const Symbol('T')));
+ expect(typeVariable.qualifiedName,
+ equals(const Symbol('MirrorsTest.Class.T')));
- expect(typedefMirror.simpleName, equals(const Symbol('Typedef')));
- expect(typedefMirror.qualifiedName,
- equals(const Symbol('MirrorsTest.Typedef')));
+ expect(typedefMirror.simpleName, equals(const Symbol('Typedef')));
+ expect(typedefMirror.qualifiedName,
+ equals(const Symbol('MirrorsTest.Typedef')));
+ }
expect(methodMirror.simpleName, equals(const Symbol('testNames')));
expect(methodMirror.qualifiedName,
@@ -214,9 +216,9 @@ mainWithArgument({bool isDart2js}) {
test("Test dart library uri", () {
testLibraryUri("test", (Uri uri) => uri == Uri.parse('dart:core'));
});
- if (isDart2js) return;
+ test("Test simple and qualifiedName", () { testNames(mirrors, isDart2js); });
+ if (isDart2js) return; // TODO(ahe): Remove this line.
kasperl 2013/05/27 12:15:33 Almost there.
test("Test reflect type", () { testReflectClass(mirrors); });
- test("Test simple and qualifiedName", () { testNames(mirrors); });
}
main() {

Powered by Google App Engine
This is Rietveld 408576698